gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove unused StripGreasedVersions function

Browse Source 
Such a function would defeat the purpose of greasing. Fortunately, we didn't
actually use it anywhere.
This commit is contained in:
Marten Seemann
2021-06-26 15:37:55 -07:00
parent e9d12b7f83
commit 9520f242e9
2 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/protocol/version.go
View File

@@ -121,14 +121,3 @@ func GetGreasedVersions(supported []VersionNumber) []VersionNumber {
copy(greased[randPos+1:], supported[randPos:])
return greased
}
// StripGreasedVersions strips all greased versions from a slice of versions
func StripGreasedVersions(versions []VersionNumber) []VersionNumber {
realVersions := make([]VersionNumber, 0, len(versions))
for _, v := range versions {
if v&0x0f0f0f0f != 0x0a0a0a0a {
realVersions = append(realVersions, v)
}
}
return realVersions
}

9
internal/protocol/version_test.go
View File

@@ -99,15 +99,6 @@ var _ = Describe("Version", func() {
Expect(isReservedVersion(greased[0])).To(BeTrue())
})
It("strips greased versions", func() {
v := SupportedVersions[0]
greased := GetGreasedVersions([]VersionNumber{v})
Expect(greased).To(HaveLen(2))
stripped := StripGreasedVersions(greased)
Expect(stripped).To(HaveLen(1))
Expect(stripped[0]).To(Equal(v))
})
It("creates greased lists of version numbers", func() {
supported := []VersionNumber{10, 18, 29}
for _, v := range supported {