From 9520f242e9cdbefb16ecd513f0f5b215c160ad31 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sat, 26 Jun 2021 15:37:55 -0700 Subject: [PATCH] remove unused StripGreasedVersions function Such a function would defeat the purpose of greasing. Fortunately, we didn't actually use it anywhere. --- internal/protocol/version.go | 11 ----------- internal/protocol/version_test.go | 9 --------- 2 files changed, 20 deletions(-) diff --git a/internal/protocol/version.go b/internal/protocol/version.go index 8e6a4f1f..9ae22fda 100644 --- a/internal/protocol/version.go +++ b/internal/protocol/version.go @@ -121,14 +121,3 @@ func GetGreasedVersions(supported []VersionNumber) []VersionNumber { copy(greased[randPos+1:], supported[randPos:]) return greased } - -// StripGreasedVersions strips all greased versions from a slice of versions -func StripGreasedVersions(versions []VersionNumber) []VersionNumber { - realVersions := make([]VersionNumber, 0, len(versions)) - for _, v := range versions { - if v&0x0f0f0f0f != 0x0a0a0a0a { - realVersions = append(realVersions, v) - } - } - return realVersions -} diff --git a/internal/protocol/version_test.go b/internal/protocol/version_test.go index b3f7962d..499d5d3f 100644 --- a/internal/protocol/version_test.go +++ b/internal/protocol/version_test.go @@ -99,15 +99,6 @@ var _ = Describe("Version", func() { Expect(isReservedVersion(greased[0])).To(BeTrue()) }) - It("strips greased versions", func() { - v := SupportedVersions[0] - greased := GetGreasedVersions([]VersionNumber{v}) - Expect(greased).To(HaveLen(2)) - stripped := StripGreasedVersions(greased) - Expect(stripped).To(HaveLen(1)) - Expect(stripped[0]).To(Equal(v)) - }) - It("creates greased lists of version numbers", func() { supported := []VersionNumber{10, 18, 29} for _, v := range supported {