gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

use explicit IP addresses in tests to fix flaky tests in travis

Browse Source
This commit is contained in:
Lucas Clemente
2016-05-07 01:04:23 +02:00
parent 16b12328fc
commit 475a2ea955
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
h2quic/server_test.go
View File

@@ -26,7 +26,7 @@ var _ = Describe("Response Writer", func() {
It("uses default handler", func() {
// We try binding to a low port number, s.t. it always fails
err := s.ListenAndServe("localhost:80", nil)
err := s.ListenAndServe("127.0.0.1:80", nil)
Expect(err).To(HaveOccurred())
Expect(s.handler).To(Equal(http.DefaultServeMux))
})
@@ -34,7 +34,7 @@ var _ = Describe("Response Writer", func() {
It("sets handler properly", func() {
h := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {})
// We try binding to a low port number, s.t. it always fails
err := s.ListenAndServe("localhost:80", h)
err := s.ListenAndServe("127.0.0.1:80", h)
Expect(err).To(HaveOccurred())
Expect(s.handler).NotTo(Equal(http.DefaultServeMux))
})

12
server_test.go
View File

@@ -77,12 +77,12 @@ var _ = Describe("Server", func() {
Expect(err).ToNot(HaveOccurred())
go func() {
defer GinkgoRecover()
err := server.ListenAndServe("localhost:13370")
err := server.ListenAndServe("127.0.0.1:13370")
Expect(err).To(HaveOccurred())
}()
time.Sleep(10 * time.Millisecond)
addr, err2 := net.ResolveUDPAddr("udp", "localhost:13370")
addr, err2 := net.ResolveUDPAddr("udp", "127.0.0.1:13370")
Expect(err2).ToNot(HaveOccurred())
conn, err2 := net.DialUDP("udp", nil, addr)
Expect(err2).ToNot(HaveOccurred())
@@ -106,12 +106,12 @@ var _ = Describe("Server", func() {
Expect(err).ToNot(HaveOccurred())
go func() {
defer GinkgoRecover()
err := server.ListenAndServe("localhost:13370")
err := server.ListenAndServe("127.0.0.1:13370")
Expect(err).To(HaveOccurred())
}()
time.Sleep(10 * time.Millisecond)
addr, err2 := net.ResolveUDPAddr("udp", "localhost:13370")
addr, err2 := net.ResolveUDPAddr("udp", "127.0.0.1:13370")
Expect(err2).ToNot(HaveOccurred())
conn, err2 := net.DialUDP("udp", nil, addr)
Expect(err2).ToNot(HaveOccurred())
@@ -131,11 +131,11 @@ var _ = Describe("Server", func() {
Expect(err).ToNot(HaveOccurred())
go func() {
defer GinkgoRecover()
err := server.ListenAndServe("localhost:13370")
err := server.ListenAndServe("127.0.0.1:13370")
Expect(err).To(HaveOccurred())
}()
addr, err := net.ResolveUDPAddr("udp", "localhost:13370")
addr, err := net.ResolveUDPAddr("udp", "127.0.0.1:13370")
Expect(err).ToNot(HaveOccurred())
// Send an invalid packet