From 475a2ea9557fe46178c9128de20cf235ebc6f535 Mon Sep 17 00:00:00 2001 From: Lucas Clemente Date: Sat, 7 May 2016 01:04:23 +0200 Subject: [PATCH] use explicit IP addresses in tests to fix flaky tests in travis --- h2quic/server_test.go | 4 ++-- server_test.go | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/h2quic/server_test.go b/h2quic/server_test.go index d6721fd1..0832428f 100644 --- a/h2quic/server_test.go +++ b/h2quic/server_test.go @@ -26,7 +26,7 @@ var _ = Describe("Response Writer", func() { It("uses default handler", func() { // We try binding to a low port number, s.t. it always fails - err := s.ListenAndServe("localhost:80", nil) + err := s.ListenAndServe("127.0.0.1:80", nil) Expect(err).To(HaveOccurred()) Expect(s.handler).To(Equal(http.DefaultServeMux)) }) @@ -34,7 +34,7 @@ var _ = Describe("Response Writer", func() { It("sets handler properly", func() { h := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {}) // We try binding to a low port number, s.t. it always fails - err := s.ListenAndServe("localhost:80", h) + err := s.ListenAndServe("127.0.0.1:80", h) Expect(err).To(HaveOccurred()) Expect(s.handler).NotTo(Equal(http.DefaultServeMux)) }) diff --git a/server_test.go b/server_test.go index c05b753e..4316b4e7 100644 --- a/server_test.go +++ b/server_test.go @@ -77,12 +77,12 @@ var _ = Describe("Server", func() { Expect(err).ToNot(HaveOccurred()) go func() { defer GinkgoRecover() - err := server.ListenAndServe("localhost:13370") + err := server.ListenAndServe("127.0.0.1:13370") Expect(err).To(HaveOccurred()) }() time.Sleep(10 * time.Millisecond) - addr, err2 := net.ResolveUDPAddr("udp", "localhost:13370") + addr, err2 := net.ResolveUDPAddr("udp", "127.0.0.1:13370") Expect(err2).ToNot(HaveOccurred()) conn, err2 := net.DialUDP("udp", nil, addr) Expect(err2).ToNot(HaveOccurred()) @@ -106,12 +106,12 @@ var _ = Describe("Server", func() { Expect(err).ToNot(HaveOccurred()) go func() { defer GinkgoRecover() - err := server.ListenAndServe("localhost:13370") + err := server.ListenAndServe("127.0.0.1:13370") Expect(err).To(HaveOccurred()) }() time.Sleep(10 * time.Millisecond) - addr, err2 := net.ResolveUDPAddr("udp", "localhost:13370") + addr, err2 := net.ResolveUDPAddr("udp", "127.0.0.1:13370") Expect(err2).ToNot(HaveOccurred()) conn, err2 := net.DialUDP("udp", nil, addr) Expect(err2).ToNot(HaveOccurred()) @@ -131,11 +131,11 @@ var _ = Describe("Server", func() { Expect(err).ToNot(HaveOccurred()) go func() { defer GinkgoRecover() - err := server.ListenAndServe("localhost:13370") + err := server.ListenAndServe("127.0.0.1:13370") Expect(err).To(HaveOccurred()) }() - addr, err := net.ResolveUDPAddr("udp", "localhost:13370") + addr, err := net.ResolveUDPAddr("udp", "127.0.0.1:13370") Expect(err).ToNot(HaveOccurred()) // Send an invalid packet