gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

qlog: use version_mismatch trigger on transport:connection_closed event (#3724)

Browse Source
This commit is contained in:
Marten Seemann
2023-03-27 00:24:30 +11:00
committed by GitHub
parent 6d7280b7dc
commit 11f493381f
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
qlog/event.go
View File

@@ -148,8 +148,7 @@ func (e eventConnectionClosed) MarshalJSONObject(enc *gojay.Encoder) {
enc.StringKey("connection_code", transportError(transportErr.ErrorCode).String())
enc.StringKey("reason", transportErr.ErrorMessage)
case errors.As(e.e, &versionNegotiationErr):
enc.StringKey("owner", ownerRemote.String())
enc.StringKey("trigger", "version_negotiation")
enc.StringKey("trigger", "version_mismatch")
}
}

5
qlog/qlog_test.go
View File

@@ -245,9 +245,8 @@ var _ = Describe("Tracing", func() {
Expect(entry.Time).To(BeTemporally("~", time.Now(), scaleDuration(10*time.Millisecond)))
Expect(entry.Name).To(Equal("transport:connection_closed"))
ev := entry.Event
Expect(ev).To(HaveLen(2))
Expect(ev).To(HaveKeyWithValue("owner", "remote"))
Expect(ev).To(HaveKeyWithValue("trigger", "version_negotiation"))
Expect(ev).To(HaveLen(1))
Expect(ev).To(HaveKeyWithValue("trigger", "version_mismatch"))
})
It("records application errors", func() {