From 11f493381ff1f34d7928cfcaf850ecd0be86cd30 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Mon, 27 Mar 2023 00:24:30 +1100 Subject: [PATCH] qlog: use version_mismatch trigger on transport:connection_closed event (#3724) --- qlog/event.go | 3 +-- qlog/qlog_test.go | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/qlog/event.go b/qlog/event.go index fbbdf1acd..9dae74441 100644 --- a/qlog/event.go +++ b/qlog/event.go @@ -148,8 +148,7 @@ func (e eventConnectionClosed) MarshalJSONObject(enc *gojay.Encoder) { enc.StringKey("connection_code", transportError(transportErr.ErrorCode).String()) enc.StringKey("reason", transportErr.ErrorMessage) case errors.As(e.e, &versionNegotiationErr): - enc.StringKey("owner", ownerRemote.String()) - enc.StringKey("trigger", "version_negotiation") + enc.StringKey("trigger", "version_mismatch") } } diff --git a/qlog/qlog_test.go b/qlog/qlog_test.go index 90d70f36e..e782b757a 100644 --- a/qlog/qlog_test.go +++ b/qlog/qlog_test.go @@ -245,9 +245,8 @@ var _ = Describe("Tracing", func() { Expect(entry.Time).To(BeTemporally("~", time.Now(), scaleDuration(10*time.Millisecond))) Expect(entry.Name).To(Equal("transport:connection_closed")) ev := entry.Event - Expect(ev).To(HaveLen(2)) - Expect(ev).To(HaveKeyWithValue("owner", "remote")) - Expect(ev).To(HaveKeyWithValue("trigger", "version_negotiation")) + Expect(ev).To(HaveLen(1)) + Expect(ev).To(HaveKeyWithValue("trigger", "version_mismatch")) }) It("records application errors", func() {