Marten Seemann bb670be93a make sure that the SHLO was sent before returning Listener.Accept ...

This fixes a race condition: In the server crypto setup, we would send
protocol.EncryptionForwardSecure on the aeadChan as soon as the SHLO was
composed, but before it was written to the crypto stream. This lead to
Listener.Accept returning the session already. If the server was ready
to write a lot of data then, this data could be sent before the crypto
setup would write on the crypto stream, therefore sending a lot of
undecryptable packets to the client, which would eventually lead to a
connection error (too many undecryptable packets).

2017-08-29 10:48:10 +07:00

14 KiB

Raw Blame History

View Raw