forked from quic-go/quic-go
Merge pull request #2472 from lucas-clemente/dont-export-qlog-on-version-negotiation
don't trigger the qlog export when receiving a Version Negotiation packet
This commit is contained in:
10
session.go
10
session.go
@@ -600,14 +600,14 @@ runLoop:
|
|||||||
}
|
}
|
||||||
|
|
||||||
s.handleCloseError(closeErr)
|
s.handleCloseError(closeErr)
|
||||||
|
if closeErr.err != errCloseForRecreating && s.qlogger != nil {
|
||||||
|
if err := s.qlogger.Export(); err != nil {
|
||||||
|
s.logger.Errorf("exporting qlog failed: %s", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
s.logger.Infof("Connection %s closed.", s.logID)
|
s.logger.Infof("Connection %s closed.", s.logID)
|
||||||
s.cryptoStreamHandler.Close()
|
s.cryptoStreamHandler.Close()
|
||||||
s.sendQueue.Close()
|
s.sendQueue.Close()
|
||||||
if s.qlogger != nil {
|
|
||||||
if err := s.qlogger.Export(); err != nil {
|
|
||||||
return err
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return closeErr.err
|
return closeErr.err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -480,7 +480,7 @@ var _ = Describe("Session", func() {
|
|||||||
sessionRunner.EXPECT().Remove(gomock.Any()).AnyTimes()
|
sessionRunner.EXPECT().Remove(gomock.Any()).AnyTimes()
|
||||||
cryptoSetup.EXPECT().Close()
|
cryptoSetup.EXPECT().Close()
|
||||||
// don't EXPECT any calls to mconn.Write()
|
// don't EXPECT any calls to mconn.Write()
|
||||||
qlogger.EXPECT().Export()
|
// don't EXPECT any call to qlogger.Export()
|
||||||
sess.closeForRecreating()
|
sess.closeForRecreating()
|
||||||
Eventually(areSessionsRunning).Should(BeFalse())
|
Eventually(areSessionsRunning).Should(BeFalse())
|
||||||
expectedRunErr = errCloseForRecreating
|
expectedRunErr = errCloseForRecreating
|
||||||
|
|||||||
Reference in New Issue
Block a user