Merge pull request #2472 from lucas-clemente/dont-export-qlog-on-version-negotiation

don't trigger the qlog export when receiving a Version Negotiation packet
This commit is contained in:
Marten Seemann
2020-04-08 22:05:13 +07:00
committed by GitHub
2 changed files with 6 additions and 6 deletions

View File

@@ -600,14 +600,14 @@ runLoop:
}
s.handleCloseError(closeErr)
if closeErr.err != errCloseForRecreating && s.qlogger != nil {
if err := s.qlogger.Export(); err != nil {
s.logger.Errorf("exporting qlog failed: %s", err)
}
}
s.logger.Infof("Connection %s closed.", s.logID)
s.cryptoStreamHandler.Close()
s.sendQueue.Close()
if s.qlogger != nil {
if err := s.qlogger.Export(); err != nil {
return err
}
}
return closeErr.err
}

View File

@@ -480,7 +480,7 @@ var _ = Describe("Session", func() {
sessionRunner.EXPECT().Remove(gomock.Any()).AnyTimes()
cryptoSetup.EXPECT().Close()
// don't EXPECT any calls to mconn.Write()
qlogger.EXPECT().Export()
// don't EXPECT any call to qlogger.Export()
sess.closeForRecreating()
Eventually(areSessionsRunning).Should(BeFalse())
expectedRunErr = errCloseForRecreating