gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

http3: send GOAWAY frame in a new Goroutine (#5114)

Browse Source 
Sending might block if the peer didn't grant enough flow
control credit.
This commit is contained in:
Marten Seemann
2025-05-04 12:21:03 +08:00
committed by GitHub
parent a0a641d59a
commit e1a1251c84
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
http3/server.go
View File

@@ -37,8 +37,6 @@ const (
streamTypeQPACKDecoderStream = 3
)
const goawayTimeout = 5 * time.Second
// A QUICEarlyListener listens for incoming QUIC connections.
type QUICEarlyListener interface {
Accept(context.Context) (quic.EarlyConnection, error)
@@ -491,10 +489,14 @@ func (s *Server) handleConn(conn quic.Connection) error {
// gracefully closed, send GOAWAY frame and wait for requests to complete or grace period to end
// new requests will be rejected and shouldn't be sent
if s.graceCtx.Err() != nil {
b = (&goAwayFrame{StreamID: nextStreamID}).Append(b[:0])
// set a deadline to send the GOAWAY frame
ctrlStr.SetWriteDeadline(time.Now().Add(goawayTimeout))
ctrlStr.Write(b)
wg.Add(1)
// Send the GOAWAY frame in a separate Goroutine.
// Sending might block if the peer didn't grant enough flow control credit.
// Write is guaranteed to return once the connection is closed.
go func() {
defer wg.Done()
_, _ = ctrlStr.Write((&goAwayFrame{StreamID: nextStreamID}).Append(nil))
}()
select {
case <-hconn.Context().Done():