gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove unused version parameter from streams map constructor

Browse Source
This commit is contained in:
Marten Seemann
2022-12-24 12:51:41 +13:00
parent d972a5e8f2
commit d4a0793b6a
3 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
connection.go
View File

@@ -530,7 +530,6 @@ func (s *connection) preSetup() {
uint64(s.config.MaxIncomingStreams), uint64(s.config.MaxIncomingStreams),
uint64(s.config.MaxIncomingUniStreams), uint64(s.config.MaxIncomingUniStreams),
s.perspective, s.perspective,
s.version,
) )
s.framer = newFramer(s.streamsMap, s.version) s.framer = newFramer(s.streamsMap, s.version)
s.receivedPackets = make(chan *receivedPacket, protocol.MaxConnUnprocessedPackets) s.receivedPackets = make(chan *receivedPacket, protocol.MaxConnUnprocessedPackets)

3
streams_map.go
View File

@@ -46,7 +46,6 @@ var errTooManyOpenStreams = errors.New("too many open streams")
type streamsMap struct { type streamsMap struct {
perspective protocol.Perspective perspective protocol.Perspective
version protocol.VersionNumber
maxIncomingBidiStreams uint64 maxIncomingBidiStreams uint64
maxIncomingUniStreams uint64 maxIncomingUniStreams uint64
@@ -70,7 +69,6 @@ func newStreamsMap(
maxIncomingBidiStreams uint64, maxIncomingBidiStreams uint64,
maxIncomingUniStreams uint64, maxIncomingUniStreams uint64,
perspective protocol.Perspective, perspective protocol.Perspective,
version protocol.VersionNumber,
) streamManager { ) streamManager {
m := &streamsMap{ m := &streamsMap{
perspective: perspective, perspective: perspective,
@@ -78,7 +76,6 @@ func newStreamsMap(
maxIncomingBidiStreams: maxIncomingBidiStreams, maxIncomingBidiStreams: maxIncomingBidiStreams,
maxIncomingUniStreams: maxIncomingUniStreams, maxIncomingUniStreams: maxIncomingUniStreams,
sender: sender, sender: sender,
version: version,
} }
m.initMaps() m.initMaps()
return m return m

2
streams_map_test.go
View File

@@ -88,7 +88,7 @@ var _ = Describe("Streams Map", func() {
BeforeEach(func() { BeforeEach(func() {
mockSender = NewMockStreamSender(mockCtrl) mockSender = NewMockStreamSender(mockCtrl)
m = newStreamsMap(mockSender, newFlowController, MaxBidiStreamNum, MaxUniStreamNum, perspective, protocol.VersionWhatever).(*streamsMap) m = newStreamsMap(mockSender, newFlowController, MaxBidiStreamNum, MaxUniStreamNum, perspective).(*streamsMap)
}) })
Context("opening", func() { Context("opening", func() {