From d4a0793b6a317d2ff79ab4cb9ce11be7c40da586 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sat, 24 Dec 2022 12:51:41 +1300 Subject: [PATCH] remove unused version parameter from streams map constructor --- connection.go | 1 - streams_map.go | 3 --- streams_map_test.go | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/connection.go b/connection.go index 0d22f6ed..6b37b35d 100644 --- a/connection.go +++ b/connection.go @@ -530,7 +530,6 @@ func (s *connection) preSetup() { uint64(s.config.MaxIncomingStreams), uint64(s.config.MaxIncomingUniStreams), s.perspective, - s.version, ) s.framer = newFramer(s.streamsMap, s.version) s.receivedPackets = make(chan *receivedPacket, protocol.MaxConnUnprocessedPackets) diff --git a/streams_map.go b/streams_map.go index 03cea9f4..237221ea 100644 --- a/streams_map.go +++ b/streams_map.go @@ -46,7 +46,6 @@ var errTooManyOpenStreams = errors.New("too many open streams") type streamsMap struct { perspective protocol.Perspective - version protocol.VersionNumber maxIncomingBidiStreams uint64 maxIncomingUniStreams uint64 @@ -70,7 +69,6 @@ func newStreamsMap( maxIncomingBidiStreams uint64, maxIncomingUniStreams uint64, perspective protocol.Perspective, - version protocol.VersionNumber, ) streamManager { m := &streamsMap{ perspective: perspective, @@ -78,7 +76,6 @@ func newStreamsMap( maxIncomingBidiStreams: maxIncomingBidiStreams, maxIncomingUniStreams: maxIncomingUniStreams, sender: sender, - version: version, } m.initMaps() return m diff --git a/streams_map_test.go b/streams_map_test.go index ad77e473..6f27368d 100644 --- a/streams_map_test.go +++ b/streams_map_test.go @@ -88,7 +88,7 @@ var _ = Describe("Streams Map", func() { BeforeEach(func() { mockSender = NewMockStreamSender(mockCtrl) - m = newStreamsMap(mockSender, newFlowController, MaxBidiStreamNum, MaxUniStreamNum, perspective, protocol.VersionWhatever).(*streamsMap) + m = newStreamsMap(mockSender, newFlowController, MaxBidiStreamNum, MaxUniStreamNum, perspective).(*streamsMap) }) Context("opening", func() {