gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

don't panic if an ACK frame has too many NACK ranges

Browse Source
This commit is contained in:
Marten Seemann
2016-06-20 14:48:21 +07:00
parent 433920fc15
commit c681fd1469
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
frames/ack_frame.go
View File

@@ -9,7 +9,10 @@ import (
"github.com/lucas-clemente/quic-go/utils"
)
var errInvalidNackRanges = errors.New("AckFrame: ACK frame contains invalid NACK ranges")
var (
errInvalidNackRanges = errors.New("AckFrame: ACK frame contains invalid NACK ranges")
errTooManyNackRanges = errors.New("AckFrame: Too many NACK ranges. Truncating not implemented.")
)
// An AckFrame in QUIC
type AckFrame struct {
@@ -60,7 +63,7 @@ func (f *AckFrame) Write(b *bytes.Buffer, version protocol.VersionNumber) error
if f.HasNACK() {
numRanges := f.numWrittenNackRanges()
if numRanges > 0xFF {
panic("Too many NACK ranges. Truncating not yet implemented.")
return errTooManyNackRanges
}
b.WriteByte(uint8(numRanges))