gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Merge pull request #945 from lucas-clemente/fix-transport-paramter-timeout-encoding

Browse Source 
fix encoding of the idle timeout for the TLS transport parameters
This commit is contained in:
Marten Seemann
2017-11-12 09:23:23 +08:00
committed by GitHub
parent 56cad16af9 11364cbd81
commit bf1ee17e67
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/handshake/transport_parameter_test.go
View File

@@ -222,7 +222,7 @@ var _ = Describe("Transport Parameters", func() {
params = &TransportParameters{ params = &TransportParameters{
StreamFlowControlWindow: 0xdeadbeef, StreamFlowControlWindow: 0xdeadbeef,
ConnectionFlowControlWindow: 0xdecafbad, ConnectionFlowControlWindow: 0xdecafbad,
IdleTimeout: 0xcafe, IdleTimeout: 0xcafe * time.Second,
} }
}) })

2
internal/handshake/transport_parameters.go
View File

@@ -150,7 +150,7 @@ func (p *TransportParameters) getTransportParameters() []transportParameter {
// TODO: use a reasonable value here // TODO: use a reasonable value here
binary.BigEndian.PutUint32(initialMaxStreamID, math.MaxUint32) binary.BigEndian.PutUint32(initialMaxStreamID, math.MaxUint32)
idleTimeout := make([]byte, 2) idleTimeout := make([]byte, 2)
binary.BigEndian.PutUint16(idleTimeout, uint16(p.IdleTimeout)) binary.BigEndian.PutUint16(idleTimeout, uint16(p.IdleTimeout/time.Second))
maxPacketSize := make([]byte, 2) maxPacketSize := make([]byte, 2)
binary.BigEndian.PutUint16(maxPacketSize, uint16(protocol.MaxReceivePacketSize)) binary.BigEndian.PutUint16(maxPacketSize, uint16(protocol.MaxReceivePacketSize))
params := []transportParameter{ params := []transportParameter{