From 11364cbd8142887c0bf659efbaeb3f548d591542 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sat, 11 Nov 2017 19:42:14 +0800 Subject: [PATCH] fix encoding of the idle timeout for the TLS transport parameters --- internal/handshake/transport_parameter_test.go | 2 +- internal/handshake/transport_parameters.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/handshake/transport_parameter_test.go b/internal/handshake/transport_parameter_test.go index 1bcfafeef..676ba6be4 100644 --- a/internal/handshake/transport_parameter_test.go +++ b/internal/handshake/transport_parameter_test.go @@ -222,7 +222,7 @@ var _ = Describe("Transport Parameters", func() { params = &TransportParameters{ StreamFlowControlWindow: 0xdeadbeef, ConnectionFlowControlWindow: 0xdecafbad, - IdleTimeout: 0xcafe, + IdleTimeout: 0xcafe * time.Second, } }) diff --git a/internal/handshake/transport_parameters.go b/internal/handshake/transport_parameters.go index 8b54d9704..bda12c277 100644 --- a/internal/handshake/transport_parameters.go +++ b/internal/handshake/transport_parameters.go @@ -150,7 +150,7 @@ func (p *TransportParameters) getTransportParameters() []transportParameter { // TODO: use a reasonable value here binary.BigEndian.PutUint32(initialMaxStreamID, math.MaxUint32) idleTimeout := make([]byte, 2) - binary.BigEndian.PutUint16(idleTimeout, uint16(p.IdleTimeout)) + binary.BigEndian.PutUint16(idleTimeout, uint16(p.IdleTimeout/time.Second)) maxPacketSize := make([]byte, 2) binary.BigEndian.PutUint16(maxPacketSize, uint16(protocol.MaxReceivePacketSize)) params := []transportParameter{