gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

use the correct error code when checking for encryption level boundaries

Browse Source
This commit is contained in:
Marten Seemann
2019-11-23 12:05:18 +07:00
parent 92b898e811
commit aefd4f83ea
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
crypto_stream.go
View File

@@ -6,6 +6,7 @@ import (
"io"
"github.com/lucas-clemente/quic-go/internal/protocol"
"github.com/lucas-clemente/quic-go/internal/qerr"
"github.com/lucas-clemente/quic-go/internal/utils"
"github.com/lucas-clemente/quic-go/internal/wire"
)
@@ -73,7 +74,7 @@ func (s *cryptoStreamImpl) HandleCryptoFrame(f *wire.CryptoFrame) error {
if s.finished {
if highestOffset > s.highestOffset {
// reject crypto data received after this stream was already finished
return errors.New("received crypto data after change of encryption level")
return qerr.Error(qerr.ProtocolViolation, "received crypto data after change of encryption level")
}
// ignore data with a smaller offset than the highest received
// could e.g. be a retransmission

2
crypto_stream_test.go
View File

@@ -119,7 +119,7 @@ var _ = Describe("Crypto Stream", func() {
err := str.HandleCryptoFrame(&wire.CryptoFrame{
Data: createHandshakeMessage(5),
})
Expect(err).To(MatchError("received crypto data after change of encryption level"))
Expect(err).To(MatchError("PROTOCOL_VIOLATION: received crypto data after change of encryption level"))
})
It("ignores crypto data below the maximum offset received before finishing", func() {