Merge pull request #1274 from lucas-clemente/remove-unused-packet-method

remove unused method from the ackhandler.Packet

internal/ackhandler/packet.go

@@ -24,18 +24,3 @@ type Packet struct {
 	isRetransmission        bool // we need a separate bool here because 0 is a valid packet number
 	retransmissionOf        protocol.PacketNumber
 }
-
-// GetFramesForRetransmission gets all the frames for retransmission
-func (p *Packet) GetFramesForRetransmission() []wire.Frame {
-	var fs []wire.Frame
-	for _, frame := range p.Frames {
-		switch frame.(type) {
-		case *wire.AckFrame:
-			continue
-		case *wire.StopWaitingFrame:
-			continue
-		}
-		fs = append(fs, frame)
-	}
-	return fs
-}

internal/ackhandler/packet_test.go

@@ -1,51 +0,0 @@
-package ackhandler
-
-import (
-	"github.com/lucas-clemente/quic-go/internal/wire"
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/gomega"
-)
-
-var _ = Describe("Packet", func() {
-	Context("getting frames for retransmission", func() {
-		ackFrame := &wire.AckFrame{LargestAcked: 13}
-		stopWaitingFrame := &wire.StopWaitingFrame{LeastUnacked: 7331}
-		maxStreamDataFrame := &wire.MaxStreamDataFrame{StreamID: 999}
-
-		streamFrame := &wire.StreamFrame{
-			StreamID: 5,
-			Data:     []byte{0x13, 0x37},
-		}
-
-		rstStreamFrame := &wire.RstStreamFrame{
-			StreamID:  555,
-			ErrorCode: 1337,
-		}
-
-		It("returns nil if there are no retransmittable frames", func() {
-			packet := &Packet{
-				Frames: []wire.Frame{ackFrame, stopWaitingFrame},
-			}
-			Expect(packet.GetFramesForRetransmission()).To(BeNil())
-		})
-
-		It("returns all retransmittable frames", func() {
-			packet := &Packet{
-				Frames: []wire.Frame{
-					maxStreamDataFrame,
-					ackFrame,
-					stopWaitingFrame,
-					streamFrame,
-					rstStreamFrame,
-				},
-			}
-			fs := packet.GetFramesForRetransmission()
-			Expect(fs).To(ContainElement(streamFrame))
-			Expect(fs).To(ContainElement(rstStreamFrame))
-			Expect(fs).To(ContainElement(maxStreamDataFrame))
-			Expect(fs).ToNot(ContainElement(stopWaitingFrame))
-			Expect(fs).ToNot(ContainElement(ackFrame))
-		})
-
-	})
-})