gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

more tests for LargestObserved in OutgoingPacketAckHandler

Browse Source
This commit is contained in:
Marten Seemann
2016-04-25 18:05:48 +07:00
parent a1d0056867
commit a3ecf2ee69
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
ackhandler/outgoing_packet_ack_handler_test.go
View File

@@ -245,6 +245,7 @@ var _ = Describe("AckHandler", func() {
}
err := handler.ReceivedAck(&ack)
Expect(err).ToNot(HaveOccurred())
Expect(handler.LargestObserved).To(Equal(protocol.PacketNumber(largestObserved)))
Expect(handler.highestInOrderAckedPacketNumber).To(Equal(protocol.PacketNumber(largestObserved)))
// all packets with packetNumbers smaller or equal largestObserved should be deleted
Expect(handler.packetHistory).ToNot(HaveKey(protocol.PacketNumber(1)))
@@ -276,6 +277,7 @@ var _ = Describe("AckHandler", func() {
err = handler.ReceivedAck(&ack)
Expect(err).To(HaveOccurred())
Expect(err).To(Equal(errDuplicateOrOutOfOrderAck))
Expect(handler.LargestObserved).To(Equal(protocol.PacketNumber(largestObserved)))
})
It("rejects ACKs with a LargestObserved packet number higher than what was sent out previously", func() {
@@ -298,11 +300,13 @@ var _ = Describe("AckHandler", func() {
}
err := handler.ReceivedAck(&ack)
Expect(err).ToNot(HaveOccurred())
Expect(handler.LargestObserved).To(Equal(protocol.PacketNumber(3)))
Expect(handler.packetHistory).ToNot(HaveKey(protocol.PacketNumber(1)))
Expect(handler.packetHistory).To(HaveKey(protocol.PacketNumber(2)))
Expect(handler.packetHistory[2].MissingReports).To(Equal(uint8(1)))
// Expect(handler.packetHistory).ToNot(HaveKey(protocol.PacketNumber(3)))
Expect(handler.packetHistory).To(HaveKey(protocol.PacketNumber(4)))
Expect(handler.LargestObserved).To(Equal(protocol.PacketNumber(3)))
})
It("handles an ACK with one NACK range and two missing packets", func() {
@@ -319,6 +323,7 @@ var _ = Describe("AckHandler", func() {
Expect(handler.packetHistory[2].MissingReports).To(Equal(uint8(1)))
Expect(handler.packetHistory[3].MissingReports).To(Equal(uint8(1)))
// Expect(handler.packetHistory).ToNot(HaveKey(protocol.PacketNumber(4)))
Expect(handler.LargestObserved).To(Equal(protocol.PacketNumber(4)))
})
It("handles an ACK with multiple NACK ranges", func() {