gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix ack frame length calculation for version <32

Browse Source
This commit is contained in:
Lucas Clemente
2016-05-11 17:09:39 +02:00
parent d17d597ebe
commit 8b1009d482
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
frames/ack_frame.go
View File

@@ -99,6 +99,7 @@ func (f *AckFrame) MinLength() protocol.ByteCount {
l += (1 + 2) * 0 /* TODO: num_timestamps */ l += (1 + 2) * 0 /* TODO: num_timestamps */
if f.HasNACK() { if f.HasNACK() {
l += 1 + (6+1)*len(f.NackRanges) l += 1 + (6+1)*len(f.NackRanges)
l++ // TODO: Remove once we drop support for <32
} }
return protocol.ByteCount(l) return protocol.ByteCount(l)
} }

2
frames/ack_frame_test.go
View File

@@ -413,7 +413,7 @@ var _ = Describe("AckFrame", func() {
LargestObserved: 4, LargestObserved: 4,
NackRanges: []NackRange{NackRange{FirstPacketNumber: 2, LastPacketNumber: 2}}, NackRanges: []NackRange{NackRange{FirstPacketNumber: 2, LastPacketNumber: 2}},
} }
err := f.Write(b, 1, protocol.PacketNumberLen6, 32) err := f.Write(b, 1, protocol.PacketNumberLen6, 31)
Expect(err).ToNot(HaveOccurred()) Expect(err).ToNot(HaveOccurred())
Expect(f.MinLength()).To(Equal(protocol.ByteCount(b.Len()))) Expect(f.MinLength()).To(Equal(protocol.ByteCount(b.Len())))
}) })