From 8b1009d482d19fdffa3a1be263486bfae7f81bb5 Mon Sep 17 00:00:00 2001 From: Lucas Clemente Date: Wed, 11 May 2016 17:09:39 +0200 Subject: [PATCH] fix ack frame length calculation for version <32 --- frames/ack_frame.go | 1 + frames/ack_frame_test.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/frames/ack_frame.go b/frames/ack_frame.go index 97266010a..192f1d389 100644 --- a/frames/ack_frame.go +++ b/frames/ack_frame.go @@ -99,6 +99,7 @@ func (f *AckFrame) MinLength() protocol.ByteCount { l += (1 + 2) * 0 /* TODO: num_timestamps */ if f.HasNACK() { l += 1 + (6+1)*len(f.NackRanges) + l++ // TODO: Remove once we drop support for <32 } return protocol.ByteCount(l) } diff --git a/frames/ack_frame_test.go b/frames/ack_frame_test.go index ac583ebe0..5d0236511 100644 --- a/frames/ack_frame_test.go +++ b/frames/ack_frame_test.go @@ -413,7 +413,7 @@ var _ = Describe("AckFrame", func() { LargestObserved: 4, NackRanges: []NackRange{NackRange{FirstPacketNumber: 2, LastPacketNumber: 2}}, } - err := f.Write(b, 1, protocol.PacketNumberLen6, 32) + err := f.Write(b, 1, protocol.PacketNumberLen6, 31) Expect(err).ToNot(HaveOccurred()) Expect(f.MinLength()).To(Equal(protocol.ByteCount(b.Len()))) })