gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove the H3_EARLY_RESPONSE error

Browse Source
This commit is contained in:
Marten Seemann
2020-07-27 12:01:53 +07:00
parent 9fa8bdff78
commit 7d29cc31f8
3 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
http3/error_codes.go
View File

@@ -23,7 +23,6 @@ const (
errorRequestRejected errorCode = 0x10b
errorRequestCanceled errorCode = 0x10c
errorRequestIncomplete errorCode = 0x10d
errorEarlyResponse errorCode = 0x10e
errorConnectError errorCode = 0x10f
errorVersionFallback errorCode = 0x110
)
@@ -58,8 +57,6 @@ func (e errorCode) String() string {
return "H3_REQUEST_CANCELLED"
case errorRequestIncomplete:
return "H3_INCOMPLETE_REQUEST"
case errorEarlyResponse:
return "H3_EARLY_RESPONSE"
case errorConnectError:
return "H3_CONNECT_ERROR"
case errorVersionFallback:

2
http3/server.go
View File

@@ -298,7 +298,7 @@ func (s *Server) handleRequest(sess quic.Session, str quic.Stream, decoder *qpac
}
// If the EOF was read by the handler, CancelRead() is a no-op.
str.CancelRead(quic.ErrorCode(errorEarlyResponse))
str.CancelRead(quic.ErrorCode(errorNoError))
return requestError{}
}

6
http3/server_test.go
View File

@@ -200,7 +200,7 @@ var _ = Describe("Server", func() {
str.EXPECT().Write(gomock.Any()).DoAndReturn(func(p []byte) (int, error) {
return responseBuf.Write(p)
}).AnyTimes()
str.EXPECT().CancelRead(quic.ErrorCode(errorEarlyResponse))
str.EXPECT().CancelRead(quic.ErrorCode(errorNoError))
str.EXPECT().Close().Do(func() { close(done) })
s.handleConn(sess)
@@ -305,7 +305,7 @@ var _ = Describe("Server", func() {
str.EXPECT().Write(gomock.Any()).DoAndReturn(func(p []byte) (int, error) {
return len(p), nil
}).AnyTimes()
str.EXPECT().CancelRead(quic.ErrorCode(errorEarlyResponse))
str.EXPECT().CancelRead(quic.ErrorCode(errorNoError))
serr := s.handleRequest(sess, str, qpackDecoder, nil)
Expect(serr.err).ToNot(HaveOccurred())
@@ -328,7 +328,7 @@ var _ = Describe("Server", func() {
str.EXPECT().Write(gomock.Any()).DoAndReturn(func(p []byte) (int, error) {
return len(p), nil
}).AnyTimes()
str.EXPECT().CancelRead(quic.ErrorCode(errorEarlyResponse))
str.EXPECT().CancelRead(quic.ErrorCode(errorNoError))
serr := s.handleRequest(sess, str, qpackDecoder, nil)
Expect(serr.err).ToNot(HaveOccurred())