gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

protocol: fix flaky TestVersionGreasing (#5051)

Browse Source
This commit is contained in:
Marten Seemann
2025-04-19 16:19:00 +08:00
committed by GitHub
parent 267cca773b
commit 7548cc069a
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/protocol/version_test.go
View File

@@ -102,18 +102,21 @@ func TestVersionGreasing(t *testing.T) {
require.Len(t, greased, 1)
require.True(t, isReservedVersion(greased[0]))
// make sure that the greased versions are distinct
// make sure that the greased versions are distinct,
// allowing for a small number of duplicates
var versions []Version
for range 20 {
for range 25 {
versions = GetGreasedVersions(versions)
}
slices.Sort(versions)
var numDuplicates int
for i, v := range versions {
require.True(t, isReservedVersion(v))
if i > 0 {
require.NotEqual(t, versions[i-1], v)
if i > 0 && versions[i-1] == v {
numDuplicates++
}
}
require.LessOrEqual(t, numDuplicates, 3)
// adding it somewhere in a slice of supported versions
supported := []Version{10, 18, 29}