gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove unused newStreamImpl from Session

Browse Source
This commit is contained in:
Marten Seemann
2017-01-06 13:15:07 +07:00
parent d0198c698a
commit 563c56fa74
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
session.go
View File

@@ -629,10 +629,6 @@ func (s *Session) OpenStream(id protocol.StreamID) (utils.Stream, error) {
return s.streamsMap.OpenStream(id)
}
func (s *Session) newStreamImpl(id protocol.StreamID) (*stream, error) {
return s.streamsMap.GetOrOpenStream(id)
}
func (s *Session) newStream(id protocol.StreamID) (*stream, error) {
stream, err := newStream(id, s.scheduleSending, s.flowControlManager)
if err != nil {

4
session_test.go
View File

@@ -257,7 +257,7 @@ var _ = Describe("Session", func() {
It("closes empty streams with error", func() {
testErr := errors.New("test")
session.newStreamImpl(5)
session.GetOrOpenStream(5)
Expect(session.streamsMap.openStreams).To(HaveLen(2))
str, _ := session.streamsMap.GetOrOpenStream(5)
Expect(str).ToNot(BeNil())
@@ -274,7 +274,7 @@ var _ = Describe("Session", func() {
// since the stream doesn't yet exist, this will throw an error
err := session.flowControlManager.UpdateHighestReceived(5, 1000)
Expect(err).To(HaveOccurred())
session.newStreamImpl(5)
session.GetOrOpenStream(5)
err = session.flowControlManager.UpdateHighestReceived(5, 2000)
Expect(err).ToNot(HaveOccurred())
})