run gometalinter with go vet

This commit is contained in:
Marten Seemann
2018-02-21 15:04:58 +08:00
parent 2f157769c0
commit 548916e902
5 changed files with 21 additions and 2 deletions

12
.gometalinter.json Normal file
View File

@@ -0,0 +1,12 @@
{
"DisableAll": true,
"Exclude": [
"vendor"
],
"Enable": [
"vet"
],
"Linters": {
"vet": "go tool vet -printfuncs=Infof,Debugf,Warningf,Errorf:PATH:LINE:MESSAGE"
}
}

View File

@@ -18,6 +18,7 @@ env:
global:
- TIMESCALE_FACTOR=20
matrix:
- TRAVIS_GOARCH=amd64 TESTMODE=lint
- TRAVIS_GOARCH=amd64 TESTMODE=unit
- TRAVIS_GOARCH=amd64 TESTMODE=integration
- TRAVIS_GOARCH=386 TESTMODE=unit

View File

@@ -3,6 +3,12 @@
set -ex
go get -t ./...
if [ ${TESTMODE} == "lint" ]; then
go get github.com/alecthomas/gometalinter
gometalinter --install
gometalinter --tests ./...
fi
if [ ${TESTMODE} == "unit" ]; then
ginkgo -r -v -cover -randomizeAllSpecs -randomizeSuites -trace -skipPackage integrationtests,benchmark
fi

View File

@@ -323,7 +323,7 @@ func (s *server) handlePacket(pconn net.PacketConn, remoteAddr net.Addr, packet
var pr *wire.PublicReset
pr, err = wire.ParsePublicReset(r)
if err != nil {
utils.Infof("Received a Public Reset for connection %x. An error occurred parsing the packet.")
utils.Infof("Received a Public Reset for connection %x. An error occurred parsing the packet.", hdr.ConnectionID)
} else {
utils.Infof("Received a Public Reset for connection %x, rejected packet number: 0x%x.", hdr.ConnectionID, pr.RejectedPacketNumber)
}

View File

@@ -148,7 +148,7 @@ func (s *serverTLS) handleInitialImpl(remoteAddr net.Addr, hdr *wire.Header, dat
sess, err := s.handleUnpackedInitial(remoteAddr, hdr, frame, aead)
if err != nil {
if ccerr := s.sendConnectionClose(remoteAddr, hdr, aead, err); ccerr != nil {
utils.Debugf("Error sending CONNECTION_CLOSE: ", ccerr)
utils.Debugf("Error sending CONNECTION_CLOSE: %s", ccerr)
}
return nil, err
}