remove stream.ReadByte

This commit is contained in:
Lucas Clemente
2016-09-05 23:22:49 +02:00
parent bc54c50b7e
commit 53ae201fd2
3 changed files with 0 additions and 35 deletions

View File

@@ -129,13 +129,6 @@ func (s *stream) Read(p []byte) (int, error) {
return bytesRead, nil
}
// ReadByte implements io.ByteReader
func (s *stream) ReadByte() (byte, error) {
p := make([]byte, 1)
_, err := io.ReadFull(s, p)
return p[0], err
}
func (s *stream) Write(p []byte) (int, error) {
s.mutex.Lock()
defer s.mutex.Unlock()

View File

@@ -150,27 +150,6 @@ var _ = Describe("Stream", func() {
Expect(b).To(Equal([]byte{0xBE, 0xEF}))
})
It("reads single bytes", func() {
frame := frames.StreamFrame{
Offset: 0,
Data: []byte{0xDE, 0xAD, 0xBE, 0xEF},
}
err := str.AddStreamFrame(&frame)
Expect(err).ToNot(HaveOccurred())
b, err := str.ReadByte()
Expect(err).ToNot(HaveOccurred())
Expect(b).To(Equal(byte(0xDE)))
b, err = str.ReadByte()
Expect(err).ToNot(HaveOccurred())
Expect(b).To(Equal(byte(0xAD)))
b, err = str.ReadByte()
Expect(err).ToNot(HaveOccurred())
Expect(b).To(Equal(byte(0xBE)))
b, err = str.ReadByte()
Expect(err).ToNot(HaveOccurred())
Expect(b).To(Equal(byte(0xEF)))
})
It("reads all data available", func() {
frame1 := frames.StreamFrame{
Offset: 0,

View File

@@ -7,16 +7,9 @@ import (
"github.com/lucas-clemente/quic-go/protocol"
)
// ReadStream is the read part of a QUIC stream
type ReadStream interface {
io.Reader
io.ByteReader
}
// Stream is the interface for QUIC streams
type Stream interface {
io.Reader
io.ByteReader
io.Writer
io.Closer
StreamID() protocol.StreamID