Merge pull request #2775 from lucas-clemente/more-linters

enable more linters, update golangci-lint to v1.31

.github/workflows/lint.yml

@@ -10,4 +10,4 @@ jobs:
         uses: golangci/golangci-lint-action@v1
         with:
           # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
-          version: v1.30
+          version: v1.31

.golangci.yml

@@ -17,10 +17,13 @@ linters-settings:
 linters:
   disable-all: true
   enable:
+    - asciicheck
     - deadcode
     - depguard
+    - exportloopref
     - goconst
     - goimports
+    - gofmt
     - gosimple
     - ineffassign
     - misspell

integrationtests/self/self_suite_test.go

@@ -116,7 +116,7 @@ var _ = BeforeSuite(func() {
 		panic(err)
 	}
 	tlsConfig = &tls.Config{
-		Certificates: []tls.Certificate{tls.Certificate{
+		Certificates: []tls.Certificate{{
 			Certificate: [][]byte{leafCert.Raw},
 			PrivateKey:  leafPrivateKey,
 		}},
@@ -260,7 +260,7 @@ func generateTLSConfigWithLongCertChain(ca *x509.Certificate, caPrivateKey *rsa.
 	rawCerts[0] = leafCert.Raw
 
 	return &tls.Config{
-		Certificates: []tls.Certificate{tls.Certificate{
+		Certificates: []tls.Certificate{{
 			Certificate: rawCerts,
 			PrivateKey:  leafPrivateKey,
 		}},