gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Merge pull request #1222 from lucas-clemente/ack-in-packet-0

Browse Source 
accept ACKs sent in packet number 0
This commit is contained in:
Marten Seemann
2018-03-07 08:02:38 +07:00
committed by GitHub
parent 2d560645f7 6efa73c36c
commit 503e3cbb3a
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
internal/ackhandler/sent_packet_handler.go
View File

@@ -157,8 +157,7 @@ func (h *sentPacketHandler) ReceivedAck(ackFrame *wire.AckFrame, withPacketNumbe
}
// duplicate or out-of-order ACK
// if withPacketNumber <= h.largestReceivedPacketWithAck && withPacketNumber != 0 {
if withPacketNumber <= h.largestReceivedPacketWithAck {
if withPacketNumber != 0 && withPacketNumber <= h.largestReceivedPacketWithAck {
return ErrDuplicateOrOutOfOrderAck
}
h.largestReceivedPacketWithAck = withPacketNumber

10
internal/ackhandler/sent_packet_handler_test.go
View File

@@ -207,6 +207,16 @@ var _ = Describe("SentPacketHandler", func() {
}
Context("ACK validation", func() {
It("accepts ACKs sent in packet 0", func() {
ack := wire.AckFrame{
LargestAcked: 5,
LowestAcked: 1,
}
err := handler.ReceivedAck(&ack, 0, protocol.EncryptionUnencrypted, time.Now())
Expect(err).ToNot(HaveOccurred())
Expect(handler.largestAcked).To(Equal(protocol.PacketNumber(5)))
})
It("rejects duplicate ACKs", func() {
largestAcked := 3
ack := wire.AckFrame{