gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

add workaround for incorrect public flag values sent by Google servers

Browse Source
This commit is contained in:
Marten Seemann
2016-12-02 19:21:42 +07:00
parent 420f5abcd7
commit 4a88422d9f
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
public_header.go
View File

@@ -157,14 +157,19 @@ func ParsePublicHeader(b *bytes.Reader, packetSentBy protocol.Perspective) (*Pub
}
if packetSentBy == protocol.PerspectiveServer && publicFlagByte&0x04 > 0 {
header.DiversificationNonce = make([]byte, 32)
for i := 0; i < 32; i++ {
var val byte
val, err = b.ReadByte()
if err != nil {
return nil, err
// TODO: remove the if once the Google servers send the correct value
// assume that a packet doesn't contain a diversification nonce if the version flag or the reset flag is set, no matter what the public flag says
// see https://github.com/lucas-clemente/quic-go/issues/232
if !header.VersionFlag && !header.ResetFlag {
header.DiversificationNonce = make([]byte, 32)
for i := 0; i < 32; i++ {
var val byte
val, err = b.ReadByte()
if err != nil {
return nil, err
}
header.DiversificationNonce[i] = val
}
header.DiversificationNonce[i] = val
}
}