gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

include the packet size in the error when packing a too large packet

Browse Source
This commit is contained in:
Marten Seemann
2018-02-05 09:17:20 +08:00
parent 30851b9a3b
commit 38c420a35b
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packet_packer.go
View File

@@ -366,8 +366,9 @@ func (p *packetPacker) writeAndSealPacket(
buffer.Write(bytes.Repeat([]byte{0}, paddingLen))
}
}
if protocol.ByteCount(buffer.Len()+sealer.Overhead()) > protocol.MaxPacketSize {
return nil, errors.New("PacketPacker BUG: packet too large")
if size := protocol.ByteCount(buffer.Len() + sealer.Overhead()); size > protocol.MaxPacketSize {
return nil, fmt.Errorf("PacketPacker BUG: packet too large (%d bytes, allowed %d bytes)", size, protocol.MaxPacketSize)
}
raw = raw[0:buffer.Len()]

3
packet_packer_test.go
View File

@@ -679,7 +679,8 @@ var _ = Describe("Packet packer", func() {
},
}
_, err := packer.PackHandshakeRetransmission(packet)
Expect(err).To(MatchError("PacketPacker BUG: packet too large"))
Expect(err).To(HaveOccurred())
Expect(err.Error()).To(ContainSubstring("PacketPacker BUG: packet too large"))
})
It("pads Initial packets to the required minimum packet size", func() {