forked from quic-go/quic-go
use the correct QUIC version in the Chrome integration tests
Because the version variable was set in the loop, we would always start a QUIC server with the lowest support QUIC version.
This commit is contained in:
@@ -34,7 +34,6 @@ const (
|
|||||||
var (
|
var (
|
||||||
nFilesUploaded int32 // should be used atomically
|
nFilesUploaded int32 // should be used atomically
|
||||||
doneCalled utils.AtomicBool
|
doneCalled utils.AtomicBool
|
||||||
version protocol.VersionNumber
|
|
||||||
)
|
)
|
||||||
|
|
||||||
func TestChrome(t *testing.T) {
|
func TestChrome(t *testing.T) {
|
||||||
@@ -83,10 +82,6 @@ func init() {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
var _ = JustBeforeEach(func() {
|
|
||||||
testserver.StartQuicServer([]protocol.VersionNumber{version})
|
|
||||||
})
|
|
||||||
|
|
||||||
var _ = AfterEach(func() {
|
var _ = AfterEach(func() {
|
||||||
testserver.StopQuicServer()
|
testserver.StopQuicServer()
|
||||||
|
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ package chrome_test
|
|||||||
import (
|
import (
|
||||||
"fmt"
|
"fmt"
|
||||||
|
|
||||||
|
"github.com/lucas-clemente/quic-go/integrationtests/tools/testserver"
|
||||||
"github.com/lucas-clemente/quic-go/internal/protocol"
|
"github.com/lucas-clemente/quic-go/internal/protocol"
|
||||||
|
|
||||||
. "github.com/onsi/ginkgo"
|
. "github.com/onsi/ginkgo"
|
||||||
@@ -10,9 +11,13 @@ import (
|
|||||||
|
|
||||||
var _ = Describe("Chrome tests", func() {
|
var _ = Describe("Chrome tests", func() {
|
||||||
for i := range protocol.SupportedVersions {
|
for i := range protocol.SupportedVersions {
|
||||||
version = protocol.SupportedVersions[i]
|
version := protocol.SupportedVersions[i]
|
||||||
|
|
||||||
Context(fmt.Sprintf("with version %s", version), func() {
|
Context(fmt.Sprintf("with version %s", version), func() {
|
||||||
|
JustBeforeEach(func() {
|
||||||
|
testserver.StartQuicServer([]protocol.VersionNumber{version})
|
||||||
|
})
|
||||||
|
|
||||||
It("downloads a small file", func() {
|
It("downloads a small file", func() {
|
||||||
chromeTest(
|
chromeTest(
|
||||||
version,
|
version,
|
||||||
|
|||||||
Reference in New Issue
Block a user