use the correct QUIC version in the Chrome integration tests

Because the version variable was set in the loop, we would always start
a QUIC server with the lowest support QUIC version.
This commit is contained in:
Marten Seemann
2018-05-22 12:50:31 +08:00
parent a3821af65a
commit 2a4eb9c132
2 changed files with 6 additions and 6 deletions

View File

@@ -34,7 +34,6 @@ const (
var (
nFilesUploaded int32 // should be used atomically
doneCalled utils.AtomicBool
version protocol.VersionNumber
)
func TestChrome(t *testing.T) {
@@ -83,10 +82,6 @@ func init() {
})
}
var _ = JustBeforeEach(func() {
testserver.StartQuicServer([]protocol.VersionNumber{version})
})
var _ = AfterEach(func() {
testserver.StopQuicServer()

View File

@@ -3,6 +3,7 @@ package chrome_test
import (
"fmt"
"github.com/lucas-clemente/quic-go/integrationtests/tools/testserver"
"github.com/lucas-clemente/quic-go/internal/protocol"
. "github.com/onsi/ginkgo"
@@ -10,9 +11,13 @@ import (
var _ = Describe("Chrome tests", func() {
for i := range protocol.SupportedVersions {
version = protocol.SupportedVersions[i]
version := protocol.SupportedVersions[i]
Context(fmt.Sprintf("with version %s", version), func() {
JustBeforeEach(func() {
testserver.StartQuicServer([]protocol.VersionNumber{version})
})
It("downloads a small file", func() {
chromeTest(
version,