gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

fix race condition in the TLS extension handler test

Browse Source
This commit is contained in:
Marten Seemann
2020-02-25 15:06:01 +07:00
parent d277e013ab
commit 25b3eb8a37
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
internal/handshake/tls_extension_handler_test.go
View File

@@ -84,12 +84,15 @@ var _ = Describe("TLS Extension Handler, for the server", func() {
}) })
It("ignores extensions that are not sent with the ClientHello", func() { It("ignores extensions that are not sent with the ClientHello", func() {
done := make(chan struct{})
go func() { go func() {
defer GinkgoRecover() defer GinkgoRecover()
handlerServer.ReceivedExtensions(uint8(typeFinished), chExts) handlerServer.ReceivedExtensions(uint8(typeFinished), chExts)
close(done)
}() }()
Consistently(handlerServer.TransportParameters()).ShouldNot(Receive()) Consistently(handlerServer.TransportParameters()).ShouldNot(Receive())
Eventually(done).Should(BeClosed())
}) })
}) })
}) })
@@ -153,12 +156,15 @@ var _ = Describe("TLS Extension Handler, for the server", func() {
}) })
It("ignores extensions that are not sent with the EncryptedExtensions", func() { It("ignores extensions that are not sent with the EncryptedExtensions", func() {
done := make(chan struct{})
go func() { go func() {
defer GinkgoRecover() defer GinkgoRecover()
handlerClient.ReceivedExtensions(uint8(typeFinished), chExts) handlerClient.ReceivedExtensions(uint8(typeFinished), chExts)
close(done)
}() }()
Consistently(handlerClient.TransportParameters()).ShouldNot(Receive()) Consistently(handlerClient.TransportParameters()).ShouldNot(Receive())
Eventually(done).Should(BeClosed())
}) })
}) })
}) })