From 25b3eb8a37afa3e2580c02e994063a5755cf3a66 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Tue, 25 Feb 2020 15:06:01 +0700 Subject: [PATCH] fix race condition in the TLS extension handler test --- internal/handshake/tls_extension_handler_test.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/internal/handshake/tls_extension_handler_test.go b/internal/handshake/tls_extension_handler_test.go index acbca466b..819497d0a 100644 --- a/internal/handshake/tls_extension_handler_test.go +++ b/internal/handshake/tls_extension_handler_test.go @@ -84,12 +84,15 @@ var _ = Describe("TLS Extension Handler, for the server", func() { }) It("ignores extensions that are not sent with the ClientHello", func() { + done := make(chan struct{}) go func() { defer GinkgoRecover() handlerServer.ReceivedExtensions(uint8(typeFinished), chExts) + close(done) }() Consistently(handlerServer.TransportParameters()).ShouldNot(Receive()) + Eventually(done).Should(BeClosed()) }) }) }) @@ -153,12 +156,15 @@ var _ = Describe("TLS Extension Handler, for the server", func() { }) It("ignores extensions that are not sent with the EncryptedExtensions", func() { + done := make(chan struct{}) go func() { defer GinkgoRecover() handlerClient.ReceivedExtensions(uint8(typeFinished), chExts) + close(done) }() Consistently(handlerClient.TransportParameters()).ShouldNot(Receive()) + Eventually(done).Should(BeClosed()) }) }) })