gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

don't require the flow control values in the transport parameters

Browse Source
This commit is contained in:
Marten Seemann
2018-08-19 10:24:46 +07:00
parent 3ff262dd7f
commit 1bb9a7e1ac
2 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
internal/handshake/transport_parameter_test.go
View File

@@ -148,18 +148,6 @@ var _ = Describe("Transport Parameters", func() {
Expect(params.DisableMigration).To(BeTrue())
})
It("rejects the parameters if the initial_max_stream_data is missing", func() {
delete(parameters, initialMaxStreamDataParameterID)
_, err := readTransportParameters(paramsMapToList(parameters))
Expect(err).To(MatchError("missing parameter"))
})
It("rejects the parameters if the initial_max_data is missing", func() {
delete(parameters, initialMaxDataParameterID)
_, err := readTransportParameters(paramsMapToList(parameters))
Expect(err).To(MatchError("missing parameter"))
})
It("rejects the parameters if the idle_timeout is missing", func() {
delete(parameters, idleTimeoutParameterID)
_, err := readTransportParameters(paramsMapToList(parameters))

6
internal/handshake/transport_parameters.go
View File

@@ -100,20 +100,16 @@ func (p *TransportParameters) getHelloMap() map[Tag][]byte {
func readTransportParameters(paramsList []transportParameter) (*TransportParameters, error) {
params := &TransportParameters{}
var foundInitialMaxStreamData bool
var foundInitialMaxData bool
var foundIdleTimeout bool
for _, p := range paramsList {
switch p.Parameter {
case initialMaxStreamDataParameterID:
foundInitialMaxStreamData = true
if len(p.Value) != 4 {
return nil, fmt.Errorf("wrong length for initial_max_stream_data: %d (expected 4)", len(p.Value))
}
params.StreamFlowControlWindow = protocol.ByteCount(binary.BigEndian.Uint32(p.Value))
case initialMaxDataParameterID:
foundInitialMaxData = true
if len(p.Value) != 4 {
return nil, fmt.Errorf("wrong length for initial_max_data: %d (expected 4)", len(p.Value))
}
@@ -151,7 +147,7 @@ func readTransportParameters(paramsList []transportParameter) (*TransportParamet
}
}
if !(foundInitialMaxStreamData && foundInitialMaxData && foundIdleTimeout) {
if !foundIdleTimeout {
return nil, errors.New("missing parameter")
}
return params, nil