diff --git a/internal/handshake/transport_parameter_test.go b/internal/handshake/transport_parameter_test.go index 518bef956..da3f67a95 100644 --- a/internal/handshake/transport_parameter_test.go +++ b/internal/handshake/transport_parameter_test.go @@ -148,18 +148,6 @@ var _ = Describe("Transport Parameters", func() { Expect(params.DisableMigration).To(BeTrue()) }) - It("rejects the parameters if the initial_max_stream_data is missing", func() { - delete(parameters, initialMaxStreamDataParameterID) - _, err := readTransportParameters(paramsMapToList(parameters)) - Expect(err).To(MatchError("missing parameter")) - }) - - It("rejects the parameters if the initial_max_data is missing", func() { - delete(parameters, initialMaxDataParameterID) - _, err := readTransportParameters(paramsMapToList(parameters)) - Expect(err).To(MatchError("missing parameter")) - }) - It("rejects the parameters if the idle_timeout is missing", func() { delete(parameters, idleTimeoutParameterID) _, err := readTransportParameters(paramsMapToList(parameters)) diff --git a/internal/handshake/transport_parameters.go b/internal/handshake/transport_parameters.go index 78e804917..f7c304aee 100644 --- a/internal/handshake/transport_parameters.go +++ b/internal/handshake/transport_parameters.go @@ -100,20 +100,16 @@ func (p *TransportParameters) getHelloMap() map[Tag][]byte { func readTransportParameters(paramsList []transportParameter) (*TransportParameters, error) { params := &TransportParameters{} - var foundInitialMaxStreamData bool - var foundInitialMaxData bool var foundIdleTimeout bool for _, p := range paramsList { switch p.Parameter { case initialMaxStreamDataParameterID: - foundInitialMaxStreamData = true if len(p.Value) != 4 { return nil, fmt.Errorf("wrong length for initial_max_stream_data: %d (expected 4)", len(p.Value)) } params.StreamFlowControlWindow = protocol.ByteCount(binary.BigEndian.Uint32(p.Value)) case initialMaxDataParameterID: - foundInitialMaxData = true if len(p.Value) != 4 { return nil, fmt.Errorf("wrong length for initial_max_data: %d (expected 4)", len(p.Value)) } @@ -151,7 +147,7 @@ func readTransportParameters(paramsList []transportParameter) (*TransportParamet } } - if !(foundInitialMaxStreamData && foundInitialMaxData && foundIdleTimeout) { + if !foundIdleTimeout { return nil, errors.New("missing parameter") } return params, nil