remove unused PacketType field from the ackhandler.Packet

internal/ackhandler/packet.go

@@ -10,7 +10,6 @@ import (
 // A Packet is a packet
 type Packet struct {
 	PacketNumber    protocol.PacketNumber
-	PacketType      protocol.PacketType
 	Frames          []wire.Frame
 	LargestAcked    protocol.PacketNumber // InvalidPacketNumber if the packet doesn't contain an ACK
 	Length          protocol.ByteCount

packet_packer.go

@@ -69,7 +69,6 @@ func (p *packedPacket) ToAckHandlerPacket() *ackhandler.Packet {
 	}
 	return &ackhandler.Packet{
 		PacketNumber:    p.header.PacketNumber,
-		PacketType:      p.header.Type,
 		LargestAcked:    largestAcked,
 		Frames:          p.frames,
 		Length:          protocol.ByteCount(len(p.raw)),

packet_packer_test.go

@@ -932,7 +932,6 @@ var _ = Describe("Packet packer", func() {
 					pnManager.EXPECT().PopPacketNumber(protocol.EncryptionInitial).Return(protocol.PacketNumber(0x42))
 					sealingManager.EXPECT().GetInitialSealer().Return(sealer, nil)
 					packet := &ackhandler.Packet{
-						PacketType:      protocol.PacketTypeHandshake,
 						EncryptionLevel: protocol.EncryptionInitial,
 						Frames:          []wire.Frame{cf},
 					}
@@ -952,7 +951,6 @@ var _ = Describe("Packet packer", func() {
 					sealingManager.EXPECT().GetInitialSealer().Return(sealer, nil)
 					packer.perspective = protocol.PerspectiveClient
 					packet := &ackhandler.Packet{
-						PacketType:      protocol.PacketTypeInitial,
 						EncryptionLevel: protocol.EncryptionInitial,
 						Frames:          []wire.Frame{cf},
 					}

session_test.go

@@ -867,10 +867,7 @@ var _ = Describe("Session", func() {
 		})
 
 		It("sends a retransmission and a regular packet in the same run", func() {
-			packetToRetransmit := &ackhandler.Packet{
-				PacketNumber: 10,
-				PacketType:   protocol.PacketTypeHandshake,
-			}
+			packetToRetransmit := &ackhandler.Packet{PacketNumber: 10}
 			retransmittedPacket := getPacket(123)
 			newPacket := getPacket(234)
 			sess.windowUpdateQueue.callback(&wire.MaxDataFrame{})
@@ -921,10 +918,7 @@ var _ = Describe("Session", func() {
 		})
 
 		It("sends a probe packet", func() {
-			packetToRetransmit := &ackhandler.Packet{
-				PacketNumber: 0x42,
-				PacketType:   protocol.PacketTypeHandshake,
-			}
+			packetToRetransmit := &ackhandler.Packet{PacketNumber: 0x42}
 			retransmittedPacket := getPacket(123)
 			sph := mockackhandler.NewMockSentPacketHandler(mockCtrl)
 			sph.EXPECT().TimeUntilSend()