gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove unused ReceiveStream.CloseRemote method (#4357)

Browse Source
This commit is contained in:
Marten Seemann
2024-03-09 19:59:43 +09:30
committed by GitHub
parent 5fd5d7770d
commit 06b421411d
2 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
receive_stream.go
View File

@@ -292,10 +292,6 @@ func (s *receiveStream) handleResetStreamFrameImpl(frame *wire.ResetStreamFrame)
return newlyRcvdFinalOffset, nil return newlyRcvdFinalOffset, nil
} }
func (s *receiveStream) CloseRemote(offset protocol.ByteCount) {
s.handleStreamFrame(&wire.StreamFrame{Fin: true, Offset: offset})
}
func (s *receiveStream) SetReadDeadline(t time.Time) error { func (s *receiveStream) SetReadDeadline(t time.Time) error {
s.mutex.Lock() s.mutex.Lock()
s.deadline = t s.deadline = t

11
receive_stream_test.go
View File

@@ -443,17 +443,6 @@ var _ = Describe("Receive Stream", func() {
Expect(atomic.LoadInt32(&numCompleted)).To(BeEquivalentTo(1)) Expect(atomic.LoadInt32(&numCompleted)).To(BeEquivalentTo(1))
}) })
}) })
It("closes when CloseRemote is called", func() {
mockFC.EXPECT().UpdateHighestReceived(protocol.ByteCount(0), true)
mockFC.EXPECT().AddBytesRead(protocol.ByteCount(0))
str.CloseRemote(0)
mockSender.EXPECT().onStreamCompleted(streamID)
b := make([]byte, 8)
n, err := strWithTimeout.Read(b)
Expect(n).To(BeZero())
Expect(err).To(MatchError(io.EOF))
})
}) })
Context("closing for shutdown", func() { Context("closing for shutdown", func() {