From 06b421411d88a805723eb01321555a205e6ead9c Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sat, 9 Mar 2024 19:59:43 +0930 Subject: [PATCH] remove unused ReceiveStream.CloseRemote method (#4357) --- receive_stream.go | 4 ---- receive_stream_test.go | 11 ----------- 2 files changed, 15 deletions(-) diff --git a/receive_stream.go b/receive_stream.go index 89d02b73..1235ff0e 100644 --- a/receive_stream.go +++ b/receive_stream.go @@ -292,10 +292,6 @@ func (s *receiveStream) handleResetStreamFrameImpl(frame *wire.ResetStreamFrame) return newlyRcvdFinalOffset, nil } -func (s *receiveStream) CloseRemote(offset protocol.ByteCount) { - s.handleStreamFrame(&wire.StreamFrame{Fin: true, Offset: offset}) -} - func (s *receiveStream) SetReadDeadline(t time.Time) error { s.mutex.Lock() s.deadline = t diff --git a/receive_stream_test.go b/receive_stream_test.go index f688433d..5438a1a0 100644 --- a/receive_stream_test.go +++ b/receive_stream_test.go @@ -443,17 +443,6 @@ var _ = Describe("Receive Stream", func() { Expect(atomic.LoadInt32(&numCompleted)).To(BeEquivalentTo(1)) }) }) - - It("closes when CloseRemote is called", func() { - mockFC.EXPECT().UpdateHighestReceived(protocol.ByteCount(0), true) - mockFC.EXPECT().AddBytesRead(protocol.ByteCount(0)) - str.CloseRemote(0) - mockSender.EXPECT().onStreamCompleted(streamID) - b := make([]byte, 8) - n, err := strWithTimeout.Read(b) - Expect(n).To(BeZero()) - Expect(err).To(MatchError(io.EOF)) - }) }) Context("closing for shutdown", func() {