forked from quic-go/quic-go
When the server is listening on multiple interfaces or interfaces with multiple IPs, the outgoing datagrams are sometime delivered with the wrong source IP address. In order to fix that, each quic connection needs to extract the destination IP (and optionally interface id) of the received datagrams, and set it as source IP (and interface) on the sent datagrams. On most platforms, this can be done using ancillary data with recvmsg() and sendmsg(). Some of the machinery for this is already there for ECN, this change extends it to read the destination IP info and write it to the outgoing packets. Fix #1736
201 lines
5.8 KiB
Go
201 lines
5.8 KiB
Go
// +build !windows
|
|
|
|
package quic
|
|
|
|
import (
|
|
"net"
|
|
"time"
|
|
|
|
"golang.org/x/sys/unix"
|
|
|
|
"github.com/lucas-clemente/quic-go/internal/protocol"
|
|
"github.com/lucas-clemente/quic-go/internal/utils"
|
|
|
|
. "github.com/onsi/ginkgo"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("OOB Conn Test", func() {
|
|
runServer := func(network, address string) (*net.UDPConn, <-chan *receivedPacket) {
|
|
addr, err := net.ResolveUDPAddr(network, address)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
udpConn, err := net.ListenUDP(network, addr)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
ecnConn, err := newConn(udpConn)
|
|
Expect(err).ToNot(HaveOccurred())
|
|
|
|
packetChan := make(chan *receivedPacket)
|
|
go func() {
|
|
defer GinkgoRecover()
|
|
for {
|
|
p, err := ecnConn.ReadPacket()
|
|
if err != nil {
|
|
return
|
|
}
|
|
packetChan <- p
|
|
}
|
|
}()
|
|
|
|
return udpConn, packetChan
|
|
}
|
|
|
|
Context("ECN conn", func() {
|
|
sendPacketWithECN := func(network string, addr *net.UDPAddr, setECN func(uintptr)) net.Addr {
|
|
conn, err := net.DialUDP(network, nil, addr)
|
|
ExpectWithOffset(1, err).ToNot(HaveOccurred())
|
|
rawConn, err := conn.SyscallConn()
|
|
ExpectWithOffset(1, err).ToNot(HaveOccurred())
|
|
ExpectWithOffset(1, rawConn.Control(func(fd uintptr) {
|
|
setECN(fd)
|
|
})).To(Succeed())
|
|
_, err = conn.Write([]byte("foobar"))
|
|
ExpectWithOffset(1, err).ToNot(HaveOccurred())
|
|
return conn.LocalAddr()
|
|
}
|
|
|
|
It("reads ECN flags on IPv4", func() {
|
|
conn, packetChan := runServer("udp4", "localhost:0")
|
|
defer conn.Close()
|
|
|
|
sentFrom := sendPacketWithECN(
|
|
"udp4",
|
|
conn.LocalAddr().(*net.UDPAddr),
|
|
func(fd uintptr) {
|
|
Expect(unix.SetsockoptInt(int(fd), unix.IPPROTO_IP, unix.IP_TOS, 2)).To(Succeed())
|
|
},
|
|
)
|
|
|
|
var p *receivedPacket
|
|
Eventually(packetChan).Should(Receive(&p))
|
|
Expect(p.rcvTime).To(BeTemporally("~", time.Now(), scaleDuration(20*time.Millisecond)))
|
|
Expect(p.data).To(Equal([]byte("foobar")))
|
|
Expect(p.remoteAddr).To(Equal(sentFrom))
|
|
Expect(p.ecn).To(Equal(protocol.ECT0))
|
|
})
|
|
|
|
It("reads ECN flags on IPv6", func() {
|
|
conn, packetChan := runServer("udp6", "[::]:0")
|
|
defer conn.Close()
|
|
|
|
sentFrom := sendPacketWithECN(
|
|
"udp6",
|
|
conn.LocalAddr().(*net.UDPAddr),
|
|
func(fd uintptr) {
|
|
Expect(unix.SetsockoptInt(int(fd), unix.IPPROTO_IPV6, unix.IPV6_TCLASS, 3)).To(Succeed())
|
|
},
|
|
)
|
|
|
|
var p *receivedPacket
|
|
Eventually(packetChan).Should(Receive(&p))
|
|
Expect(p.rcvTime).To(BeTemporally("~", time.Now(), scaleDuration(20*time.Millisecond)))
|
|
Expect(p.data).To(Equal([]byte("foobar")))
|
|
Expect(p.remoteAddr).To(Equal(sentFrom))
|
|
Expect(p.ecn).To(Equal(protocol.ECNCE))
|
|
})
|
|
|
|
It("reads ECN flags on a connection that supports both IPv4 and IPv6", func() {
|
|
conn, packetChan := runServer("udp", "0.0.0.0:0")
|
|
defer conn.Close()
|
|
port := conn.LocalAddr().(*net.UDPAddr).Port
|
|
|
|
// IPv4
|
|
sendPacketWithECN(
|
|
"udp4",
|
|
&net.UDPAddr{IP: net.IPv4(127, 0, 0, 1), Port: port},
|
|
func(fd uintptr) {
|
|
Expect(unix.SetsockoptInt(int(fd), unix.IPPROTO_IP, unix.IP_TOS, 3)).To(Succeed())
|
|
},
|
|
)
|
|
|
|
var p *receivedPacket
|
|
Eventually(packetChan).Should(Receive(&p))
|
|
Expect(utils.IsIPv4(p.remoteAddr.(*net.UDPAddr).IP)).To(BeTrue())
|
|
Expect(p.ecn).To(Equal(protocol.ECNCE))
|
|
|
|
// IPv6
|
|
sendPacketWithECN(
|
|
"udp6",
|
|
&net.UDPAddr{IP: net.IPv6loopback, Port: port},
|
|
func(fd uintptr) {
|
|
Expect(unix.SetsockoptInt(int(fd), unix.IPPROTO_IPV6, unix.IPV6_TCLASS, 1)).To(Succeed())
|
|
},
|
|
)
|
|
|
|
Eventually(packetChan).Should(Receive(&p))
|
|
Expect(utils.IsIPv4(p.remoteAddr.(*net.UDPAddr).IP)).To(BeFalse())
|
|
Expect(p.ecn).To(Equal(protocol.ECT1))
|
|
})
|
|
})
|
|
|
|
Context("Packet Info conn", func() {
|
|
sendPacket := func(network string, addr *net.UDPAddr) net.Addr {
|
|
conn, err := net.DialUDP(network, nil, addr)
|
|
ExpectWithOffset(1, err).ToNot(HaveOccurred())
|
|
_, err = conn.Write([]byte("foobar"))
|
|
ExpectWithOffset(1, err).ToNot(HaveOccurred())
|
|
return conn.LocalAddr()
|
|
}
|
|
|
|
It("reads packet info on IPv4", func() {
|
|
conn, packetChan := runServer("udp4", ":0")
|
|
defer conn.Close()
|
|
|
|
addr := conn.LocalAddr().(*net.UDPAddr)
|
|
ip := net.ParseIP("127.0.0.1").To4()
|
|
addr.IP = ip
|
|
sentFrom := sendPacket("udp4", addr)
|
|
|
|
var p *receivedPacket
|
|
Eventually(packetChan).Should(Receive(&p))
|
|
Expect(p.rcvTime).To(BeTemporally("~", time.Now(), scaleDuration(20*time.Millisecond)))
|
|
Expect(p.data).To(Equal([]byte("foobar")))
|
|
Expect(p.remoteAddr).To(Equal(sentFrom))
|
|
Expect(p.info).To(Not(BeNil()))
|
|
Expect(p.info.addr.To4()).To(Equal(ip))
|
|
})
|
|
|
|
It("reads packet info on IPv6", func() {
|
|
conn, packetChan := runServer("udp6", ":0")
|
|
defer conn.Close()
|
|
|
|
addr := conn.LocalAddr().(*net.UDPAddr)
|
|
ip := net.ParseIP("::1")
|
|
addr.IP = ip
|
|
sentFrom := sendPacket("udp6", addr)
|
|
|
|
var p *receivedPacket
|
|
Eventually(packetChan).Should(Receive(&p))
|
|
Expect(p.rcvTime).To(BeTemporally("~", time.Now(), scaleDuration(20*time.Millisecond)))
|
|
Expect(p.data).To(Equal([]byte("foobar")))
|
|
Expect(p.remoteAddr).To(Equal(sentFrom))
|
|
Expect(p.info).To(Not(BeNil()))
|
|
Expect(p.info.addr).To(Equal(ip))
|
|
})
|
|
|
|
It("reads packet info on a connection that supports both IPv4 and IPv6", func() {
|
|
conn, packetChan := runServer("udp", ":0")
|
|
defer conn.Close()
|
|
port := conn.LocalAddr().(*net.UDPAddr).Port
|
|
|
|
// IPv4
|
|
ip4 := net.ParseIP("127.0.0.1").To4()
|
|
sendPacket("udp4", &net.UDPAddr{IP: ip4, Port: port})
|
|
|
|
var p *receivedPacket
|
|
Eventually(packetChan).Should(Receive(&p))
|
|
Expect(utils.IsIPv4(p.remoteAddr.(*net.UDPAddr).IP)).To(BeTrue())
|
|
Expect(p.info).To(Not(BeNil()))
|
|
Expect(p.info.addr.To4()).To(Equal(ip4))
|
|
|
|
// IPv6
|
|
ip6 := net.ParseIP("::1")
|
|
sendPacket("udp6", &net.UDPAddr{IP: net.IPv6loopback, Port: port})
|
|
|
|
Eventually(packetChan).Should(Receive(&p))
|
|
Expect(utils.IsIPv4(p.remoteAddr.(*net.UDPAddr).IP)).To(BeFalse())
|
|
Expect(p.info).To(Not(BeNil()))
|
|
Expect(p.info.addr).To(Equal(ip6))
|
|
})
|
|
})
|
|
})
|