package quic import ( "bytes" "github.com/golang/mock/gomock" "github.com/lucas-clemente/quic-go/internal/mocks" "github.com/lucas-clemente/quic-go/internal/protocol" "github.com/lucas-clemente/quic-go/internal/wire" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" ) var _ = Describe("Stream Framer", func() { const ( id1 = protocol.StreamID(10) id2 = protocol.StreamID(11) ) var ( retransmittedFrame1, retransmittedFrame2 *wire.StreamFrame framer *streamFramer streamsMap *streamsMap stream1, stream2 *mocks.MockStreamI ) setNoData := func(str *mocks.MockStreamI) { str.EXPECT().PopStreamFrame(gomock.Any()).AnyTimes() } BeforeEach(func() { retransmittedFrame1 = &wire.StreamFrame{ StreamID: 5, Data: []byte{0x13, 0x37}, } retransmittedFrame2 = &wire.StreamFrame{ StreamID: 6, Data: []byte{0xDE, 0xCA, 0xFB, 0xAD}, } stream1 = mocks.NewMockStreamI(mockCtrl) stream1.EXPECT().StreamID().Return(protocol.StreamID(5)).AnyTimes() stream2 = mocks.NewMockStreamI(mockCtrl) stream2.EXPECT().StreamID().Return(protocol.StreamID(6)).AnyTimes() streamsMap = newStreamsMap(nil, protocol.PerspectiveServer, versionGQUICFrames) streamsMap.putStream(stream1) streamsMap.putStream(stream2) framer = newStreamFramer(nil, streamsMap, versionGQUICFrames) }) It("says if it has retransmissions", func() { Expect(framer.HasFramesForRetransmission()).To(BeFalse()) framer.AddFrameForRetransmission(retransmittedFrame1) Expect(framer.HasFramesForRetransmission()).To(BeTrue()) }) It("sets the DataLenPresent for dequeued retransmitted frames", func() { setNoData(stream1) setNoData(stream2) framer.AddFrameForRetransmission(retransmittedFrame1) fs := framer.PopStreamFrames(protocol.MaxByteCount) Expect(fs).To(HaveLen(1)) Expect(fs[0].DataLenPresent).To(BeTrue()) }) Context("Popping", func() { It("returns nil when popping an empty framer", func() { setNoData(stream1) setNoData(stream2) Expect(framer.PopStreamFrames(1000)).To(BeEmpty()) }) It("pops frames for retransmission", func() { setNoData(stream1) setNoData(stream2) framer.AddFrameForRetransmission(retransmittedFrame1) framer.AddFrameForRetransmission(retransmittedFrame2) fs := framer.PopStreamFrames(1000) Expect(fs).To(Equal([]*wire.StreamFrame{retransmittedFrame1, retransmittedFrame2})) // make sure the frames are actually removed, and not returned a second time Expect(framer.PopStreamFrames(1000)).To(BeEmpty()) }) It("doesn't pop frames for retransmission, if the size would be smaller than the minimum STREAM frame size", func() { framer.AddFrameForRetransmission(&wire.StreamFrame{ StreamID: id1, Data: bytes.Repeat([]byte{'a'}, int(protocol.MinStreamFrameSize)), }) fs := framer.PopStreamFrames(protocol.MinStreamFrameSize - 1) Expect(fs).To(BeEmpty()) }) It("pops frames for retransmission, even if the remaining space in the packet is too small, if the frame doesn't need to be split", func() { setNoData(stream1) setNoData(stream2) framer.AddFrameForRetransmission(retransmittedFrame1) fs := framer.PopStreamFrames(protocol.MinStreamFrameSize - 1) Expect(fs).To(Equal([]*wire.StreamFrame{retransmittedFrame1})) }) It("pops frames for retransmission, if the remaining size is the miniumum STREAM frame size", func() { framer.AddFrameForRetransmission(retransmittedFrame1) fs := framer.PopStreamFrames(protocol.MinStreamFrameSize) Expect(fs).To(Equal([]*wire.StreamFrame{retransmittedFrame1})) }) It("returns normal frames", func() { setNoData(stream2) f := &wire.StreamFrame{ StreamID: id1, Data: []byte("foobar"), Offset: 42, } stream1.EXPECT().PopStreamFrame(gomock.Any()).Return(f) fs := framer.PopStreamFrames(1000) Expect(fs).To(Equal([]*wire.StreamFrame{f})) }) It("returns multiple normal frames", func() { f1 := &wire.StreamFrame{Data: []byte("foobar")} f2 := &wire.StreamFrame{Data: []byte("foobaz")} stream1.EXPECT().PopStreamFrame(gomock.Any()).Return(f1) stream2.EXPECT().PopStreamFrame(gomock.Any()).Return(f2) fs := framer.PopStreamFrames(1000) Expect(fs).To(HaveLen(2)) Expect(fs).To(ContainElement(f1)) Expect(fs).To(ContainElement(f2)) }) It("returns retransmission frames before normal frames", func() { setNoData(stream2) f1 := &wire.StreamFrame{Data: []byte("foobar")} stream1.EXPECT().PopStreamFrame(gomock.Any()).Return(f1) framer.AddFrameForRetransmission(retransmittedFrame1) fs := framer.PopStreamFrames(1000) Expect(fs).To(Equal([]*wire.StreamFrame{retransmittedFrame1, f1})) }) It("does not pop empty frames", func() { setNoData(stream1) setNoData(stream2) fs := framer.PopStreamFrames(500) Expect(fs).To(BeEmpty()) }) It("pops frames that have the minimum size", func() { stream1.EXPECT().PopStreamFrame(protocol.MinStreamFrameSize).Return(&wire.StreamFrame{Data: []byte("foobar")}) framer.PopStreamFrames(protocol.MinStreamFrameSize) }) It("does not pop frames smaller than the mimimum size", func() { // don't expect a call to PopStreamFrame() framer.PopStreamFrames(protocol.MinStreamFrameSize - 1) }) It("uses the round-robin scheduling", func() { stream1.EXPECT().PopStreamFrame(gomock.Any()).Return(&wire.StreamFrame{ StreamID: id1, Data: []byte("foobar"), }) stream1.EXPECT().PopStreamFrame(gomock.Any()).MaxTimes(1) stream2.EXPECT().PopStreamFrame(gomock.Any()).Return(&wire.StreamFrame{ StreamID: id2, Data: []byte("foobaz"), }) stream2.EXPECT().PopStreamFrame(gomock.Any()).MaxTimes(1) fs := framer.PopStreamFrames(protocol.MinStreamFrameSize) Expect(fs).To(HaveLen(1)) // it doesn't matter here if this data is from stream1 or from stream2... firstStreamID := fs[0].StreamID fs = framer.PopStreamFrames(protocol.MinStreamFrameSize) Expect(fs).To(HaveLen(1)) // ... but the data popped this time has to be from the other stream Expect(fs[0].StreamID).ToNot(Equal(firstStreamID)) }) It("stops iterating when the remaining size is smaller than the minimum STREAM frame size", func() { // pop a frame such that the remaining size is one byte less than the minimum STREAM frame size f := &wire.StreamFrame{ StreamID: id1, Data: bytes.Repeat([]byte("f"), int(500-protocol.MinStreamFrameSize)), } stream1.EXPECT().PopStreamFrame(protocol.ByteCount(500)).Return(f) setNoData(stream2) fs := framer.PopStreamFrames(500) Expect(fs).To(Equal([]*wire.StreamFrame{f})) }) Context("splitting of frames", func() { It("splits off nothing", func() { f := &wire.StreamFrame{ StreamID: 1, Data: []byte("bar"), Offset: 3, } Expect(maybeSplitOffFrame(f, 1000)).To(BeNil()) Expect(f.Offset).To(Equal(protocol.ByteCount(3))) Expect(f.Data).To(Equal([]byte("bar"))) }) It("splits off initial frame", func() { f := &wire.StreamFrame{ StreamID: 1, Data: []byte("foobar"), DataLenPresent: true, Offset: 3, FinBit: true, } previous := maybeSplitOffFrame(f, 3) Expect(previous).ToNot(BeNil()) Expect(previous.StreamID).To(Equal(protocol.StreamID(1))) Expect(previous.Data).To(Equal([]byte("foo"))) Expect(previous.DataLenPresent).To(BeTrue()) Expect(previous.Offset).To(Equal(protocol.ByteCount(3))) Expect(previous.FinBit).To(BeFalse()) Expect(f.StreamID).To(Equal(protocol.StreamID(1))) Expect(f.Data).To(Equal([]byte("bar"))) Expect(f.DataLenPresent).To(BeTrue()) Expect(f.Offset).To(Equal(protocol.ByteCount(6))) Expect(f.FinBit).To(BeTrue()) }) It("splits a frame", func() { frame := &wire.StreamFrame{Data: bytes.Repeat([]byte{0}, 600)} framer.AddFrameForRetransmission(frame) fs := framer.PopStreamFrames(500) Expect(fs).To(HaveLen(1)) minLength := fs[0].MinLength(framer.version) Expect(minLength + fs[0].DataLen()).To(Equal(protocol.ByteCount(500))) Expect(framer.retransmissionQueue[0].Data).To(HaveLen(int(600 - fs[0].DataLen()))) Expect(framer.retransmissionQueue[0].Offset).To(Equal(fs[0].DataLen())) }) It("only removes a frame from the framer after returning all split parts", func() { setNoData(stream1) setNoData(stream2) frameHeaderLen := protocol.ByteCount(4) frame := &wire.StreamFrame{Data: bytes.Repeat([]byte{0}, int(501-frameHeaderLen))} framer.AddFrameForRetransmission(frame) fs := framer.PopStreamFrames(500) Expect(fs).To(HaveLen(1)) Expect(framer.retransmissionQueue).ToNot(BeEmpty()) fs = framer.PopStreamFrames(500) Expect(fs).To(HaveLen(1)) Expect(fs[0].DataLen()).To(BeEquivalentTo(1)) Expect(framer.retransmissionQueue).To(BeEmpty()) }) }) }) })