From fe02bc2b665989f744b672ca694db8a4e11e4078 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sun, 11 May 2025 12:12:26 +0800 Subject: [PATCH] http3: fix flaky TestClientRequestLengthLimit (#5137) --- http3/client_test.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/http3/client_test.go b/http3/client_test.go index e0e92a6eb..76a3ece7e 100644 --- a/http3/client_test.go +++ b/http3/client_test.go @@ -254,10 +254,8 @@ func TestClientRequestLengthLimit(t *testing.T) { str.EXPECT().Read(gomock.Any()).DoAndReturn( bytes.NewReader(encodeResponse(t, http.StatusTeapot)).Read, ).AnyTimes() - str.EXPECT().CancelWrite(quic.StreamErrorCode(ErrCodeRequestCanceled)).Do(func(quic.StreamErrorCode) { - close(done) - }) - str.EXPECT().Close() + str.EXPECT().CancelWrite(quic.StreamErrorCode(ErrCodeRequestCanceled)) + str.EXPECT().Close().Do(func() error { close(done); return nil }) conn.EXPECT().OpenStreamSync(gomock.Any()).Return(str, nil) cc := (&Transport{}).NewClientConn(conn)