gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

connection parameter manager docs

Browse Source
This commit is contained in:
Lucas Clemente
2016-05-05 23:36:41 +02:00
parent 7e0d59a5e6
commit f7d3da74b7
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
handshake/connection_parameters_manager.go
View File

@@ -11,9 +11,10 @@ import (
) )
// ConnectionParametersManager stores the connection parameters // ConnectionParametersManager stores the connection parameters
// Warning: Writes may only be done from the crypto stream, see the comment
// in GetSHLOMap().
type ConnectionParametersManager struct { type ConnectionParametersManager struct {
params map[Tag][]byte params map[Tag][]byte
// TODO: We can probably remove this mutex.
mutex sync.RWMutex mutex sync.RWMutex
} }
@@ -56,7 +57,9 @@ func (h *ConnectionParametersManager) GetRawValue(tag Tag) ([]byte, error) {
// GetSHLOMap gets all values (except crypto values) needed for the SHLO // GetSHLOMap gets all values (except crypto values) needed for the SHLO
func (h *ConnectionParametersManager) GetSHLOMap() map[Tag][]byte { func (h *ConnectionParametersManager) GetSHLOMap() map[Tag][]byte {
// TODO: This races. // Since GetSHLOMap is only called from the crypto stream, and changes to
// the params are only made by the crypto stream itself, there is no data race
// here, and we need not copy the map.
return h.params return h.params
} }