From f4efe4349896351a46fca75b63ca232482ffa903 Mon Sep 17 00:00:00 2001
From: Lucas Clemente <lucas@clemente.io>
Date: Thu, 4 Aug 2016 10:56:50 +0200
Subject: [PATCH] use docker exec instead of mounting to work around a travis
 issue

---
 integrationtests/chrome_test.go               | 22 +-----
 .../integrationtests_suite_test.go            | 79 +++++++++++--------
 2 files changed, 48 insertions(+), 53 deletions(-)

diff --git a/integrationtests/chrome_test.go b/integrationtests/chrome_test.go
index 19b75fc2..77203a68 100644
--- a/integrationtests/chrome_test.go
+++ b/integrationtests/chrome_test.go
@@ -4,8 +4,6 @@ import (
 	"fmt"
 	"io"
 	"net/http"
-	"os"
-	"path/filepath"
 
 	"github.com/tebeka/selenium"
 
@@ -120,23 +118,11 @@ var _ = Describe("Chrome tests", func() {
 				close(done)
 			}, 10)
 
-			It("downloads a small file", func(done Done) {
-				var err error
-				err = wd.Get("https://quic.clemente.io/data")
+			It("downloads a small file", func() {
+				err := wd.Get("https://quic.clemente.io/data")
 				Expect(err).NotTo(HaveOccurred())
-				var file *os.File
-				Eventually(func() error {
-					file, err = os.Open(filepath.Join(downloadDir, "data"))
-					return err
-				}, 30, 0.1).ShouldNot(HaveOccurred())
-				fi, err := file.Stat()
-				Expect(err).ToNot(HaveOccurred())
-				Eventually(fi.Size(), 10, 0.1).Should(Equal(int64(dataLen)))
-				contents := make([]byte, dataLen)
-				_, err = file.Read(contents)
-				Expect(err).ToNot(HaveOccurred())
-				Expect(contents).To(Equal(data))
-				close(done)
+				Eventually(func() int { return getDownloadSize("data") }, 30, 0.1).Should(Equal(dataLen))
+				Expect(getDownloadMD5("data")).To(Equal(dataMD5))
 			}, 60)
 		})
 	}
diff --git a/integrationtests/integrationtests_suite_test.go b/integrationtests/integrationtests_suite_test.go
index dd179fe7..fa306c6c 100644
--- a/integrationtests/integrationtests_suite_test.go
+++ b/integrationtests/integrationtests_suite_test.go
@@ -1,15 +1,15 @@
 package integrationtests
 
 import (
+	"bytes"
+	"crypto/md5"
 	"crypto/rand"
+	"encoding/hex"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"net"
 	"net/http"
-	"os"
 	"os/exec"
-	"path/filepath"
 	"strconv"
 	"time"
 
@@ -31,10 +31,10 @@ const (
 )
 
 var (
-	server      *h2quic.Server
-	data        []byte
-	port        string
-	downloadDir string
+	server  *h2quic.Server
+	data    []byte
+	dataMD5 []byte
+	port    string
 
 	docker *gexec.Session
 )
@@ -47,7 +47,6 @@ func TestIntegration(t *testing.T) {
 var _ = BeforeSuite(func() {
 	setupHTTPHandlers()
 	setupQuicServer()
-	setupDownloadDir()
 	setupSelenium()
 })
 
@@ -56,18 +55,15 @@ var _ = AfterSuite(func() {
 	Expect(err).NotTo(HaveOccurred())
 
 	stopSelenium()
-	removeDownloadDir()
 }, 5)
 
-var _ = AfterEach(func() {
-	clearDownloadDir()
-})
-
 func setupHTTPHandlers() {
 	defer GinkgoRecover()
 	data = make([]byte, dataLen)
 	_, err := rand.Read(data)
 	Expect(err).NotTo(HaveOccurred())
+	sum := md5.Sum(data)
+	dataMD5 = sum[:]
 
 	http.HandleFunc("/hello", func(w http.ResponseWriter, r *http.Request) {
 		defer GinkgoRecover()
@@ -121,7 +117,7 @@ func setupSelenium() {
 		"-i",
 		"--rm",
 		"-p=4444:4444",
-		fmt.Sprintf("-v=%s/:/home/seluser/Downloads/", downloadDir),
+		"--name", "quic-test-selenium",
 		"lclemente/standalone-chrome:latest",
 	)
 	docker, err = gexec.Start(dockerCmd, GinkgoWriter, GinkgoWriter)
@@ -173,30 +169,43 @@ func GetLocalIP() string {
 	panic("no addr")
 }
 
-// create a temporary directory for Chrome downloads
-// Docker will mount the Chrome download directory here
-func setupDownloadDir() {
-	var err error
-	downloadDir, err = ioutil.TempDir("/tmp", "quicgodownloads")
-	Expect(err).ToNot(HaveOccurred())
+func removeDownload(filename string) {
+	cmd := exec.Command("docker", "exec", "-i", "quic-test-selenium", "rm", "-f", "/home/seluser/Downloads/"+filename)
+	session, err := gexec.Start(cmd, GinkgoWriter, GinkgoWriter)
+	Expect(err).NotTo(HaveOccurred())
+	Eventually(session).Should(gexec.Exit(0))
 }
 
-// delete all files in the download directory
-func clearDownloadDir() {
-	d, err := os.Open(downloadDir)
-	defer d.Close()
-	Expect(err).ToNot(HaveOccurred())
-	filenames, err := d.Readdirnames(-1)
-	Expect(err).ToNot(HaveOccurred())
-	for _, filename := range filenames {
-		err := os.Remove(filepath.Join(downloadDir, filename))
-		Expect(err).ToNot(HaveOccurred())
+var _ = AfterEach(func() {
+	removeDownload("data")
+})
+
+func getDownloadSize(filename string) int {
+	var out bytes.Buffer
+	cmd := exec.Command("docker", "exec", "-i", "quic-test-selenium", "stat", "--printf=%s", "/home/seluser/Downloads/"+filename)
+	session, err := gexec.Start(cmd, &out, GinkgoWriter)
+	Expect(err).NotTo(HaveOccurred())
+	Eventually(session).Should(gexec.Exit())
+	if session.ExitCode() != 0 {
+		return 0
 	}
+	Expect(out.Bytes()).ToNot(BeEmpty())
+	size, err := strconv.Atoi(string(out.Bytes()))
+	Expect(err).NotTo(HaveOccurred())
+	return size
 }
 
-// delete the download directory
-// must be empty when calling this function
-func removeDownloadDir() {
-	err := os.Remove(downloadDir)
-	Expect(err).ToNot(HaveOccurred())
+func getDownloadMD5(filename string) []byte {
+	var out bytes.Buffer
+	cmd := exec.Command("docker", "exec", "-i", "quic-test-selenium", "md5sum", "/home/seluser/Downloads/"+filename)
+	session, err := gexec.Start(cmd, &out, GinkgoWriter)
+	Expect(err).NotTo(HaveOccurred())
+	Eventually(session).Should(gexec.Exit())
+	if session.ExitCode() != 0 {
+		return nil
+	}
+	Expect(out.Bytes()).ToNot(BeEmpty())
+	res, err := hex.DecodeString(string(out.Bytes()[0:32]))
+	Expect(err).NotTo(HaveOccurred())
+	return res
 }