From f4bb3c12be761c83b23405be74f4cd876c4d1ea3 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Tue, 30 Jul 2019 11:17:26 +0700 Subject: [PATCH] remove unneeded tracking variable in the received packet history The value was not updated correctly when receiving reordered packets. Since it's trivial to determine it from the list of received packets, the easiest fix is to remove it. --- internal/ackhandler/received_packet_history.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/internal/ackhandler/received_packet_history.go b/internal/ackhandler/received_packet_history.go index 629beb24e..d449bc51d 100644 --- a/internal/ackhandler/received_packet_history.go +++ b/internal/ackhandler/received_packet_history.go @@ -12,8 +12,6 @@ import ( // It does not store packet contents. type receivedPacketHistory struct { ranges *utils.PacketIntervalList - - lowestInReceivedPacketNumbers protocol.PacketNumber } var errTooManyOutstandingReceivedAckRanges = qerr.Error(qerr.InternalError, "Too many outstanding received ACK ranges") @@ -77,11 +75,6 @@ func (h *receivedPacketHistory) ReceivedPacket(p protocol.PacketNumber) error { // DeleteBelow deletes all entries below (but not including) p func (h *receivedPacketHistory) DeleteBelow(p protocol.PacketNumber) { - if p <= h.lowestInReceivedPacketNumbers { - return - } - h.lowestInReceivedPacketNumbers = p - nextEl := h.ranges.Front() for el := h.ranges.Front(); nextEl != nil; el = nextEl { nextEl = el.Next()