protocol: remove VersionWhatever, previously used for testing (#3763)

internal/protocol/version.go

@@ -18,12 +18,11 @@ const (
 
 // The version numbers, making grepping easier
 const (
-	VersionTLS      VersionNumber = 0x1
-	VersionWhatever VersionNumber = math.MaxUint32 - 1 // for when the version doesn't matter
-	VersionUnknown  VersionNumber = math.MaxUint32
-	VersionDraft29  VersionNumber = 0xff00001d
-	Version1        VersionNumber = 0x1
-	Version2        VersionNumber = 0x6b3343cf
+	VersionTLS     VersionNumber = 0x1
+	VersionUnknown VersionNumber = math.MaxUint32
+	VersionDraft29 VersionNumber = 0xff00001d
+	Version1       VersionNumber = 0x1
+	Version2       VersionNumber = 0x6b3343cf
 )
 
 // SupportedVersions lists the versions that the server supports
@@ -43,8 +42,6 @@ func (vn VersionNumber) String() string {
 	}
 	//nolint:exhaustive
 	switch vn {
-	case VersionWhatever:
-		return "whatever"
 	case VersionUnknown:
 		return "unknown"
 	case VersionDraft29:

internal/protocol/version_test.go

@@ -12,7 +12,6 @@ var _ = Describe("Version", func() {
 
 	It("says if a version is valid", func() {
 		Expect(IsValidVersion(VersionTLS)).To(BeTrue())
-		Expect(IsValidVersion(VersionWhatever)).To(BeFalse())
 		Expect(IsValidVersion(VersionUnknown)).To(BeFalse())
 		Expect(IsValidVersion(VersionDraft29)).To(BeTrue())
 		Expect(IsValidVersion(Version1)).To(BeTrue())
@@ -25,7 +24,6 @@ var _ = Describe("Version", func() {
 	})
 
 	It("has the right string representation", func() {
-		Expect(VersionWhatever.String()).To(Equal("whatever"))
 		Expect(VersionUnknown.String()).To(Equal("unknown"))
 		Expect(VersionDraft29.String()).To(Equal("draft-29"))
 		Expect(Version1.String()).To(Equal("v1"))