gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

gracefully handle invalid ACK delay values when parsing ACK frames

Browse Source
This commit is contained in:
Marten Seemann
2019-08-17 12:42:10 +07:00
parent 7df59b855f
commit f0bdf4f982
2 changed files with 23 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
internal/wire/ack_frame_test.go
View File

@@ -3,6 +3,7 @@ package wire
import (
"bytes"
"io"
"math"
"time"
"github.com/lucas-clemente/quic-go/internal/protocol"
@@ -129,6 +130,20 @@ var _ = Describe("ACK Frame (for IETF QUIC)", func() {
}
})
It("gracefully handles overflows of the delay time", func() {
data := []byte{0x2}
data = append(data, encodeVarInt(100)...) // largest acked
data = append(data, encodeVarInt(math.MaxUint64/5)...) // delay
data = append(data, encodeVarInt(0)...) // num blocks
data = append(data, encodeVarInt(0)...) // first ack block
b := bytes.NewReader(data)
frame, err := parseAckFrame(b, protocol.AckDelayExponent, versionIETFFrames)
Expect(err).ToNot(HaveOccurred())
Expect(frame.DelayTime).To(BeNumerically(">", 0))
// The maximum encodable duration is ~292 years.
Expect(frame.DelayTime.Hours()).To(BeNumerically("~", 292*365*24, 365*24))
})
It("errors on EOF", func() {
data := []byte{0x2}
data = append(data, encodeVarInt(1000)...) // largest acked