gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

close the quic client on protocol errors in h2quic client

Browse Source
This commit is contained in:
Marten Seemann
2016-12-19 14:41:44 +07:00
parent 44271a8ec8
commit edb34b1765
2 changed files with 35 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
h2quic/client_test.go
View File

@@ -14,11 +14,12 @@ import (
)
type mockQuicClient struct {
streams map[protocol.StreamID]*mockStream
streams map[protocol.StreamID]*mockStream
closeErr error
}
func (m *mockQuicClient) Close(error) error { panic("not implemented") }
func (m *mockQuicClient) Listen() error { panic("not implemented") }
func (m *mockQuicClient) Close(e error) error { m.closeErr = e; return nil }
func (m *mockQuicClient) Listen() error { panic("not implemented") }
func (m *mockQuicClient) OpenStream(id protocol.StreamID) (utils.Stream, error) {
_, ok := m.streams[id]
if ok {
@@ -121,6 +122,28 @@ var _ = Describe("Client", func() {
close(done)
})
It("closes the quic client when encountering an error on the header stream", func() {
req, err := http.NewRequest("https", "https://quic.clemente.io:1337/file1.dat", nil)
Expect(err).ToNot(HaveOccurred())
headerStream.dataToRead.Write([]byte("invalid response"))
go client.handleHeaderStream()
var doRsp *http.Response
var doErr error
var doReturned bool
go func() {
doRsp, doErr = client.Do(req)
doReturned = true
}()
Eventually(func() bool { return doReturned }).Should(BeTrue())
Expect(client.headerErr).To(HaveOccurred())
Expect(doErr).To(MatchError(client.headerErr))
Expect(doRsp).To(BeNil())
Expect(client.client.(*mockQuicClient).closeErr).To(MatchError(client.headerErr))
})
Context("validating the address", func() {
It("refuses to do requests for the wrong host", func() {
req, err := http.NewRequest("https", "https://quic.clemente.io:1336/foobar.html", nil)