gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

http3: fix flaky TestConnControlStreamFailure (#5188)

Browse Source
This commit is contained in:
Marten Seemann
2025-05-31 16:21:17 +08:00
committed by GitHub
parent f8a1711ce7
commit eb427b599e
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
http3/conn_test.go
View File

@@ -207,6 +207,12 @@ func testConnControlStreamFailures(t *testing.T, data []byte, readErr error, exp
_, err = controlStr.Write(quicvarint.Append(nil, streamTypeControlStream)) _, err = controlStr.Write(quicvarint.Append(nil, streamTypeControlStream))
require.NoError(t, err) require.NoError(t, err)
done := make(chan struct{})
go func() {
defer close(done)
conn.handleUnidirectionalStreams(nil)
}()
switch readErr { switch readErr {
case nil: case nil:
_, err = controlStr.Write(data) _, err = controlStr.Write(data)
@@ -223,11 +229,6 @@ func testConnControlStreamFailures(t *testing.T, data []byte, readErr error, exp
conn.openRequestStream(context.Background(), nil, nil, true, 1000) conn.openRequestStream(context.Background(), nil, nil, true, 1000)
done := make(chan struct{})
go func() {
defer close(done)
conn.handleUnidirectionalStreams(nil)
}()
select { select {
case <-serverConn.Context().Done(): case <-serverConn.Context().Done():
require.ErrorIs(t, require.ErrorIs(t,