From e6ecb1f40c36373a8ac970bcaa2e76ad1e2b8eb4 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Wed, 22 Jun 2016 16:32:56 +0700 Subject: [PATCH] remove unused GetHighestInOrderPacketNumber method from QUIC 34 ACK frame ref #182 --- frames/ack_frame_new.go | 8 -------- frames/ack_frame_new_test.go | 9 --------- 2 files changed, 17 deletions(-) diff --git a/frames/ack_frame_new.go b/frames/ack_frame_new.go index fa084bad..1ce4e0fd 100644 --- a/frames/ack_frame_new.go +++ b/frames/ack_frame_new.go @@ -296,14 +296,6 @@ func (f *AckFrameNew) HasMissingRanges() bool { return false } -// GetHighestInOrderPacketNumber gets the highest in order packet number that is confirmed by this ACK -func (f *AckFrameNew) GetHighestInOrderPacketNumber() protocol.PacketNumber { - if f.HasMissingRanges() { - panic("NACKs not yet implemented") - } - return f.LargestObserved -} - func (f *AckFrameNew) validateAckRanges() bool { if len(f.AckRanges) == 0 { return true diff --git a/frames/ack_frame_new_test.go b/frames/ack_frame_new_test.go index baab25e0..ef008699 100644 --- a/frames/ack_frame_new_test.go +++ b/frames/ack_frame_new_test.go @@ -574,13 +574,4 @@ var _ = Describe("AckFrame", func() { Expect(ack.validateAckRanges()).To(BeTrue()) }) }) - - Context("highest in order packet number", func() { - It("gets the hightest in order packet number for a simple ACK", func() { - frame := &AckFrameNew{ - LargestObserved: 0x1337, - } - Expect(frame.GetHighestInOrderPacketNumber()).To(Equal(protocol.PacketNumber(0x1337))) - }) - }) })