gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

store the end of the NACK range instead of its length

Browse Source
This commit is contained in:
Marten Seemann
2016-04-21 18:28:50 +07:00
parent 88cd62e7fe
commit e5559d37d3
4 changed files with 32 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ackhandler/ack_handler.go
View File

@@ -40,12 +40,12 @@ func (h *AckHandler) GetNackRanges() []*frames.NackRange {
if !inRange {
r := &frames.NackRange{
FirstPacketNumber: packetNumber,
Length: 1,
LastPacketNumber: packetNumber,
}
ranges = append(ranges, r)
inRange = true
} else {
ranges[len(ranges)-1].Length++
ranges[len(ranges)-1].LastPacketNumber++
}
} else {
inRange = false

12
ackhandler/ack_handler_test.go
View File

@@ -29,7 +29,7 @@ var _ = Describe("AckHandler", func() {
nackRanges := ackHandler.GetNackRanges()
Expect(len(nackRanges)).To(Equal(1))
Expect(nackRanges[0].FirstPacketNumber).To(Equal(protocol.PacketNumber(5)))
Expect(nackRanges[0].Length).To(Equal(uint8(1)))
Expect(nackRanges[0].LastPacketNumber).To(Equal(protocol.PacketNumber(5)))
})
It("handles two consecutive lost packages", func() {
@@ -44,7 +44,7 @@ var _ = Describe("AckHandler", func() {
nackRanges := ackHandler.GetNackRanges()
Expect(len(nackRanges)).To(Equal(1))
Expect(nackRanges[0].FirstPacketNumber).To(Equal(protocol.PacketNumber(5)))
Expect(nackRanges[0].Length).To(Equal(uint8(2)))
Expect(nackRanges[0].LastPacketNumber).To(Equal(protocol.PacketNumber(6)))
})
It("handles two non-consecutively lost packages", func() {
@@ -59,9 +59,9 @@ var _ = Describe("AckHandler", func() {
nackRanges := ackHandler.GetNackRanges()
Expect(len(nackRanges)).To(Equal(2))
Expect(nackRanges[0].FirstPacketNumber).To(Equal(protocol.PacketNumber(3)))
Expect(nackRanges[0].Length).To(Equal(uint8(1)))
Expect(nackRanges[0].LastPacketNumber).To(Equal(protocol.PacketNumber(3)))
Expect(nackRanges[1].FirstPacketNumber).To(Equal(protocol.PacketNumber(7)))
Expect(nackRanges[1].Length).To(Equal(uint8(1)))
Expect(nackRanges[1].LastPacketNumber).To(Equal(protocol.PacketNumber(7)))
})
It("handles two sequences of lost packages", func() {
@@ -76,9 +76,9 @@ var _ = Describe("AckHandler", func() {
nackRanges := ackHandler.GetNackRanges()
Expect(len(nackRanges)).To(Equal(2))
Expect(nackRanges[0].FirstPacketNumber).To(Equal(protocol.PacketNumber(2)))
Expect(nackRanges[0].Length).To(Equal(uint8(3)))
Expect(nackRanges[0].LastPacketNumber).To(Equal(protocol.PacketNumber(4)))
Expect(nackRanges[1].FirstPacketNumber).To(Equal(protocol.PacketNumber(7)))
Expect(nackRanges[1].Length).To(Equal(uint8(2)))
Expect(nackRanges[1].LastPacketNumber).To(Equal(protocol.PacketNumber(8)))
})
})